From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Lv Zheng <lv.zheng@intel.com>,
gregkh@linuxfoundation.org, linaro-kernel@lists.linaro.org,
sboyd@codeaurora.org, arnd@arndb.de, stable@vger.kernel.org,
Len Brown <lenb@kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'
Date: Wed, 16 Sep 2015 04:06:07 +0200 [thread overview]
Message-ID: <2327281.tcr4Ty65Wu@vostro.rjw.lan> (raw)
In-Reply-To: <1515364.kIriLUmZv6@vostro.rjw.lan>
On Wednesday, September 16, 2015 03:57:05 AM Rafael J. Wysocki wrote:
> On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote:
> > global_lock is defined as an unsigned long and accessing only its lower
> > 32 bits from sysfs is incorrect, as we need to consider other 32 bits
> > for big endian 64 bit systems.
> >
> > Fix that by making global_lock an u32 instead.
> >
> > Cc: <stable@vger.kernel.org> # v4.1+
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > ---
> > Its marked just for # v4.1+, because arm64 has the first 64 big-endian
> > platform with ACPI. And ACPI support for that is mainlined recently
> > only (Arnd Bergmann).
>
> OK
>
> So are you aware of any ARM platform implementing the ACPI EC?
>
> I am not. Moreover, I'm not aware of any plans in that area.
In any case, please just split the EC-related changes off from your second
patch and send them separately.
Thanks,
Rafael
next prev parent reply other threads:[~2015-09-16 1:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 8:34 Viresh Kumar
2015-09-16 1:57 ` Rafael J. Wysocki
2015-09-16 2:06 ` Rafael J. Wysocki [this message]
2015-09-16 1:59 ` Viresh Kumar
2015-09-23 7:52 ` Zheng, Lv
2015-09-24 23:37 ` Viresh Kumar
2015-09-23 9:15 ` Sudeep Holla
2015-09-23 9:39 ` Arnd Bergmann
2015-09-23 9:57 ` Sudeep Holla
2015-09-23 10:29 ` Arnd Bergmann
2015-09-25 0:17 ` Rafael J. Wysocki
2015-09-25 0:03 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2327281.tcr4Ty65Wu@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®