From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751582AbaCYJNU (ORCPT ); Tue, 25 Mar 2014 05:13:20 -0400 Received: from m13-127.163.com ([220.181.13.127]:37380 "EHLO m13-127.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbaCYJNQ (ORCPT ); Tue, 25 Mar 2014 05:13:16 -0400 X-Greylist: delayed 928 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 Mar 2014 05:13:15 EDT X-Originating-IP: [202.108.100.231] Date: Tue, 25 Mar 2014 16:56:20 +0800 (CST) From: "wei zhang" To: "David Miller" Cc: xeb@mail.ru, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err() X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20131204(24406.5820.5783) Copyright (c) 2002-2014 www.mailtech.cn 163com In-Reply-To: <20140324.151417.474668383309974516.davem@davemloft.net> References: <1395646471-637-1-git-send-email-asuka.com@163.com> <20140324.151417.474668383309974516.davem@davemloft.net> Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Message-ID: <232812eb.b291.144f87462d4.Coremail.asuka.com@163.com> X-CM-TRANSID: f8GowEDJZEC1RDFT2q0bAA--.1106W X-CM-SenderInfo: 5dvxytoofrzqqrwthudrp/1tbiMhlZ1lD-rjrikwACss X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s2P9EA5Q020222 At 2014-03-25 03:14:17,"David Miller"  wrote: >From: Wei Zhang  >Date: Mon, 24 Mar 2014 15:34:31 +0800 > >> When use the gre vport, openvswitch register a gre_cisco_protocol but >> does not supply a err_handler with it. The gre_cisco_err() call the >> err_handler without existence check, cause the kernel crash. >>  >> This patch base on v3.14-rc7. But the bug affect all kernel newer than >> 3.11! >>  >> Signed-off-by: Wei Zhang  > >Rather, openvswitch should provide an appropriate ->err_handler() that >returns PACKET_RCVD or PACKET_REJECT. Thank you for your explanation, I misunderstand it . I'm very sorry about this bothering! > >I'm not applying this patch.{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I