mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "kogiidena" <kogiidena@eggplant.ddo.jp>
To: "Richard Purdie" <rpurdie@rpsys.net>
Cc: linux-kernel@vger.kernel.org, lethal@linux-sh.org
Subject: Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports
Date: Wed, 9 May 2007 22:45:16 +0900 (JST)	[thread overview]
Message-ID: <2329.192.168.1.10.1178718316.squirrel@eggplant.ddo.jp> (raw)
In-Reply-To: <1178712861.6291.5.camel@localhost.localdomain>

> On Wed, 2007-05-09 at 20:42 +0900, kogiidena wrote:
>> >As far as I can tell, the existing timer trigger can do everything the
>> >blink trigger can (and more besides).
>> I want to blink LED in the initial state.
>
> Are you after to set that per LED or would some standard configurable
> default for all LEDs work?
I'm sorry.The meaning of the question cannot be understood.
My LED is use in the following.
I want to blink LED while booting it.
When boot ends, LED is turned on.

> The approach is probably a good idea but you'll have to split struct
> timer_list timer from the data structure.
>
> Also, if default_trigger wasn't the timer trigger you have a nice oops
> waiting to happen.
I'm sorry that it is not possible to understand enough.
Please teach concretely.

I think that I become more convenient if the argument can be given to "default_trigger" for "all trigger".

kogiidena
-------------------------------
 Use example -- part of leds-landisk.c
-------------------------------
static struct timer_trig_data default_timer_trig_data = {
        .delay_on  = 250,
        .delay_off = 250,
};

static struct led_classdev landisk_leds[] = {
        [0] = {
                        .name = "power",
                        .brightness_set = landisk_led_set,
                        .default_trigger = "timer",
                        .default_trigger_data = &default_timer_trig_data,
               },
        [1] = {
                        .name = "status",
                        .brightness_set = landisk_led_set,
                        .default_trigger = "timer",
                        .default_trigger_data = &default_timer_trig_data,
               },
        [2] = {


  reply	other threads:[~2007-05-09 13:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-08 12:27 kogiidena
2007-05-08 12:46 ` Richard Purdie
2007-05-09 11:42   ` kogiidena
2007-05-09 12:14     ` Richard Purdie
2007-05-09 13:45       ` kogiidena [this message]
2007-05-09 15:06         ` Richard Purdie
2007-05-09 22:18           ` kogiidena
2007-05-11 15:02             ` kogiidena
2007-05-12  4:01               ` kogiidena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2329.192.168.1.10.1178718316.squirrel@eggplant.ddo.jp \
    --to=kogiidena@eggplant.ddo.jp \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®