From: Liran Alon <liran.alon@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Revert "kvm: nVMX: Restrict VMX capability MSR changes"
Date: Mon, 20 Jan 2020 19:16:34 +0200 [thread overview]
Message-ID: <232F8FDD-D53E-4FA4-95A5-8BC06BCB6685@oracle.com> (raw)
In-Reply-To: <30525d58-10de-abb4-8dad-228da766ff82@redhat.com>
> On 20 Jan 2020, at 17:41, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 20/01/20 16:11, Vitaly Kuznetsov wrote:
>>
>> RFC. I think the check for vmx->nested.vmxon is legitimate for everything
>> but restore so removing it (what I do with the revert) is likely a no-go.
>> I'd like to gather opinions on the proper fix: should we somehow check
>> that the vCPU is in 'restore' start (has never being run) and make
>> KVM_SET_MSRS pass or should we actually mandate that KVM_SET_NESTED_STATE
>> is run after KVM_SET_MSRS by userspace?
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> I think this should be fixed in QEMU, by doing KVM_SET_MSRS for feature
> MSRs way earlier.
I agree.
> I'll do it since I'm currently working on a patch to
> add a KVM_SET_MSR for the microcode revision.
Please Cc me.
Thanks,
-Liran
prev parent reply other threads:[~2020-01-20 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 15:11 Vitaly Kuznetsov
2020-01-20 15:41 ` Paolo Bonzini
2020-01-20 16:33 ` Vitaly Kuznetsov
2020-01-20 16:40 ` Paolo Bonzini
2020-01-20 17:16 ` Liran Alon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=232F8FDD-D53E-4FA4-95A5-8BC06BCB6685@oracle.com \
--to=liran.alon@oracle.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®