From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A15771F2B8D for ; Tue, 7 Jul 2026 21:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783458340; cv=none; b=QdUD/S97Clul5iHHTIYLl/l/RMhMa/e6p/wLvEUmFGml1tS3s/klUw4O/rWSpBXnTkoUJ85OpyxHhSg0uD+TQHdO6f+VVdCiuaerdECmyWywtZJP2DP4AWgG7AyelzH2s4HN8g4YnOkRKeSWiJFQ+ecLeun6WtICoXlnra6h0x0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783458340; c=relaxed/simple; bh=8PKmof1mmNuwdqG0MY5eC6LUcGb1WWzUUyF4Dq3A8zE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=J11rMfTqlcPdexaGLzEVCWcMo3RnqC7AmmR2XA6tWr2x3y3/jjHDCE+seySmv7TitfN7gcSlYA0hawazHYhsib5nVICR9wKgeVjW14VEDBgdV20+I5x34gD09AvbXb6BmsqHWVyIGfPYOcxKgniXcV/1beHrEy7wMp3gMQm514s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jBczVG2T; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OxBl/x/U; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jBczVG2T"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OxBl/x/U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783458338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8PKmof1mmNuwdqG0MY5eC6LUcGb1WWzUUyF4Dq3A8zE=; b=jBczVG2TSdzj8JQptDvovCCmf/gnWlPPZ8xuFlMJzXaCMXMz5KaGiH72Dq4ffRBooWh4hu ul1NbrzE+wGNSzA3BhlaITvrB37AkfQokm7Jnj1GbSxx0JfqHIITQkoPbxRoQSpkuFTlu7 1a8bWG5WACug+ELwuuVeffmJBfd8keA= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-uYG6amG-NAC9Yxh9H0Mmmw-1; Tue, 07 Jul 2026 17:05:37 -0400 X-MC-Unique: uYG6amG-NAC9Yxh9H0Mmmw-1 X-Mimecast-MFC-AGG-ID: uYG6amG-NAC9Yxh9H0Mmmw_1783458337 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8eeba1d9e47so395876d6.2 for ; Tue, 07 Jul 2026 14:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783458337; x=1784063137; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8PKmof1mmNuwdqG0MY5eC6LUcGb1WWzUUyF4Dq3A8zE=; b=OxBl/x/UpdTfOyoet/DsoHmhQNtPn3R5nw9RtzZgyUcrspmTVwKxV9NELHLRX73q4O GvQg+5zQQ5+alRBfHncKEE1jZXDvYspKlauONS9zqOSyYA6y5WmUjy6LoczuXbzen5wk wU2D6eW0kyEkzjmyiVDIoQCuMQBqxx01tt36K8lkXaAZC7W+M8gYeP0bPe5FDrEjvSBG Z6pekhdWpaP2Agh+A5Bs5Smvk175/rZqIK5YpJwN2fvNffEa3Ev7Fm/KXFGD2EFhI+rH q+r2LGHovDWxw0OATFiT+O4chDZtWmsfrRLRKp2y3+Xh9KVBK5KaJD+072moJIP4fzuS oYew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783458337; x=1784063137; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8PKmof1mmNuwdqG0MY5eC6LUcGb1WWzUUyF4Dq3A8zE=; b=tJrsA7ralfn9xt8spcweizUgCBPopAui5BHivY2/M5ia1E0GyHQuD9ltal8KPo5x2S 94SGlXIAqk2Hs24uNJEpnJJV5xXibckhohNuT7PcR/ybYybqXAQMG0S6M8QvIwcxXvc0 x1ifI5Atj6JptI6QSTbgl6QbyPe+OUvIUx0al3tcV1p1p6UHZS3VkCe/hRAo9yVr+3QK 7EP0h5oPoHPM1GUZabjx8f4QhlWF5hvN6rPB1TxqrFxq75InKKCrGMNEV6SpdMG6UZOI YxYV63OTFkU9oDY32Q5Fe0mLzVeZqZuzvl8tC3THjxTlVmy88Enw+hNzq8Z8GyaKicN2 EVsg== X-Forwarded-Encrypted: i=1; AHgh+RpxriSgX+CkXQssscXq+Z9OlIZ72cx/mxbNPL/6X5lM3londaoCpidVV+WtamuzlRw3roONr8d8XcuMDWQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzdxeMqz9ZQ493mXC2TNjDAm9SlqLFybQEeETdyHLCLlcrvspv2 +U/Yp2PrOZ2DPzpNqv5jhAThLSDULONEd3K8TgKUKONiOaIJhC1m3biUC8P/wShuJawoiZLg5RH yOWjmHpWYCdtMbx3BGunhQmqPZqkG7Q0YLv5yyo5D3yHBfb+IufGqoXZQZa74LmMMRg== X-Gm-Gg: AfdE7ck9H6sWusRPHALtdOaZVs1WmMU9jS97FEoKy0Qn6E6W7A/5wgFqjDAmJqkVEMO hvler3UhiU3qnou4wrrbRc+Zin0KyXMax+vkM3RaK2T0S1hGo8kvKmhGPoaMB7x65r0wxQ76fbI BIJ/SBJToigJPRlmlj3soyU2Jzx1klF7fuxzsV9wsEn9y8JQEvqm3HlyuhFWfukES/w/IVODrhi KGRjMoGzQ45gSKV6OcJa4CVH3P0k/2+0TDUg8w088O/tz9r2G8rY7X+2rsQ73o7Snenhl9c6/Sb sAjPe74YjD7QuhbFA09ZB36IX/kDinBlDQQOWp75lVneeDJ2a80fXaHeWUOrHyDApmvCohzAUjW ZktuWLtY= X-Received: by 2002:ac8:5806:0:b0:51b:efbb:fbc with SMTP id d75a77b69052e-51c74829b78mr71428981cf.33.1783458336832; Tue, 07 Jul 2026 14:05:36 -0700 (PDT) X-Received: by 2002:ac8:5806:0:b0:51b:efbb:fbc with SMTP id d75a77b69052e-51c74829b78mr71428471cf.33.1783458336294; Tue, 07 Jul 2026 14:05:36 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41db4fb5sm118175811cf.25.2026.07.07.14.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 14:05:34 -0700 (PDT) Message-ID: <232b31667248cf58b1365aba58573494f81b21b8.camel@redhat.com> Subject: Re: [PATCH RFC 0/2] rust: sync: create lock class using `#[track_caller]` From: lyude@redhat.com To: Gary Guo , Peter Zijlstra Cc: Boqun Feng , Alice Ryhl , Daniel Almeida , Onur =?ISO-8859-1?Q?=D6zkan?= , Miguel Ojeda , =?ISO-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Tamir Duberstein , Alexandre Courbot , Ingo Molnar , Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Date: Tue, 07 Jul 2026 17:05:33 -0400 In-Reply-To: References: <20260703-rust_lockdep-v1-0-1c21c62d0341@garyguo.net> <20260703140140.GE651302@noisy.programming.kicks-ass.net> <20260703223242.GS751831@noisy.programming.kicks-ass.net> <20260704171042.GT751831@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-07-04 at 18:46 +0100, Gary Guo wrote: >=20 > It's certainly possible to give explicit names (this is what patch > 1/2's > "new_with_name" function is for). To mandate names being provided we > just need > to remove the constructor function without the name. That said, I am > not sure > that we want everyone to explicitly give names. Especially for types > like > delayed_work where it needs two lock classes and names, it's somewhat > leaky abstraction if the constructor asks to user to provide a name > for its > work completion and a name for its timer (as it's not possible to > concat strings > without allocation without using macros). >=20 I think it's also worth mentioning too: this doesn't really make that much of a difference compared to how lockdep names are currently generated in the upstream kernel with Rust. If anything, this sort of change would make it a lot easier to actually improve the auto- generated names we come up with in the future. > Best, > Gary