From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E84B028850C for ; Mon, 19 Jan 2026 06:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768805826; cv=none; b=pZu85IERVdteiamqiigeHDFJ4xuD2scHcOq5FfYkoBwTDoVjDwCNiTRUT3+iTHa7Q+MHsfxxsDnCtnvsQBDlVNNlVRvU2hrK3zCtDlVN851H0pygsGsZ6iq92QyXSz+DUqfsWGMLrb1prRD1gZ3UpXYj2RooFmsRAbmnfGmZGYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768805826; c=relaxed/simple; bh=aQWBRFtJtLPkK/LkUfhkL/td9DQqg4tFR5gfqj4QI40=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gzWLrK7RIhntVUWKNXgGOIdFgx6R/yJMO1N+VGiymGi1yswxHEhhFdKPajY5MyPNaDMVspquf7I98tGl6etWW2qKAkqpA6nyYVm+ShvdJL8AHtLcqyU8V3jld3Sa208VeVetuM5uNvlb5gKA6y3JOai5/rMpkgJg3x1G8QZ5olI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GuxQbyaF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=PM5i55NL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GuxQbyaF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="PM5i55NL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768805824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U7wcPigaqRC6JM0r5LtbYtiW9wo9Ugj074EGL3sYK8Q=; b=GuxQbyaFYL+8IfqPsUhHMniAba0LG78oGzK1HBeuN/uc8+4SB32XEPsqYDBACsdzVWAY7Y Fq0OEBeGbLM61PZGMWUyjUGkiqhj6VCden35cGP886QYn/239CpQiQOCxvdRiUg9zorRKE sDG+BMcS5t6zyU0xxJomq0rzz5QTwM4= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-PoqZpxANPGCtyUW1wBmXTg-1; Mon, 19 Jan 2026 01:57:02 -0500 X-MC-Unique: PoqZpxANPGCtyUW1wBmXTg-1 X-Mimecast-MFC-AGG-ID: PoqZpxANPGCtyUW1wBmXTg_1768805821 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c5539b9adb8so2339926a12.2 for ; Sun, 18 Jan 2026 22:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768805821; x=1769410621; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U7wcPigaqRC6JM0r5LtbYtiW9wo9Ugj074EGL3sYK8Q=; b=PM5i55NLE8aUpojuoCP0CWOjYZFfgc0IZdOp8cQxOzMFm/tt0FTbOh8L/+eils2uO0 xEGdBiJGy7TzjHjCppE5RB2lxlv0qKDfvuCujAzsNZ2l7ew2HMiEZXJslUieUsVsM7e4 CkT3/lwBHQygieIuiR9dNxSy8WlIcyEHka+9lTaWGmEvC3kNXoL0dfV6K9T70Et/xR3E fICLi+gOSOnzupheiFNfvdFnEMGIwTS7nt9T6DMBemCHI1Pe7UsNdtVnF3ujuZ1ZRpuE OuG9Vli+tc2pdDfiXbtDQqyP/g75c2T6S4F5e6MMH5Vmj6PkcS03teBl2Qe60k9k6mGY O1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768805821; x=1769410621; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U7wcPigaqRC6JM0r5LtbYtiW9wo9Ugj074EGL3sYK8Q=; b=VP01YTjLlxLz4lsmiJAjNPr+CMiW/FM7n+3NC/fwJdJl+Lg6QVnbG88AzUucJtjRVl f3/WffqcYQuZeah4MbujFw1RI5ern+U/0v7l3/u2OvoOhqBkqM1R16IFpOgp/FkOg72F SOSfWn0QXBE0mWy381DNpqFRSqcMw+F5XRTpJluOvk+MXRIVkq75KmIFDWFSxB/WVZ4Z zm5nyAKnvd+xt+ZBltF2E/Z21yav06pqechFPwPJ01YHfFEo9zgTsxlRm1b77OA4U9Da 7x9xevWhSKc/KRMUsKbNt5mwJtkmKzxvJbHVggTwcCzDHyVj5vLXXSjTTj+QiRrY3AYy 1A+Q== X-Forwarded-Encrypted: i=1; AJvYcCVvHU3cFrsXcmf6scvKtmiwYbToh1yscAvy2HF1b1veu3JutrZCIYFW14lzW+Tztq2B03ssA1vV8Yst0Xs=@vger.kernel.org X-Gm-Message-State: AOJu0YxKOw0Jw3jm1Q6o3MhAQm1baa9XugBXoZcgNS7qkWgZPBxsNIYd /XU5iGOW7C//PUR+J4wXEMTKtovdwy28FMQS/73IHOnoM1gr0H5qvOSXU5Gf+T/QavlwkHOd1ez 3fGHS+4UytTozbz3LBgoNRnoqtlhzyQAfrkmWuqawxpHs7vptJ6MYsrXWY+rpQWZiOg== X-Gm-Gg: AY/fxX591uGyIzOkE7Z7aIvyoXbaukcDOnAyuQqsQpQLdYMHNTM5VxvR2iRW9ZW6rlL 9q65Kz9NkDBh1us89TsNF69+Hmx+RR56xgIVMG6wHvHMCevp1Mbmv1Jg71BB0wFazriEF46BnVs jhlwEULM4aNdDWTd5xft3WKhPNWTXzcxeZtDFYt+jtsImqm3lUEHTk+X5vxM172I8LrqR8w12ui vNeWyCSHK0tqVpizcRRZqy+GXYrh/11ZGMTXiMNAChIzx9cFixo0WqvicDVMkpxKOr1CvbZgHvu SN5rRJGjIGoEl2FO7tjXEqimAiEpZyCe0kk7EZ9vz9ZL89m0MmAnsp2LlCXdkjFLJtnFWTicWdy oJJ2c2VK7TDs= X-Received: by 2002:a05:6a00:600b:b0:81f:41c8:765a with SMTP id d2e1a72fcca58-81f9f68fbdfmr10063444b3a.4.1768805821390; Sun, 18 Jan 2026 22:57:01 -0800 (PST) X-Received: by 2002:a05:6a00:600b:b0:81f:41c8:765a with SMTP id d2e1a72fcca58-81f9f68fbdfmr10063416b3a.4.1768805821075; Sun, 18 Jan 2026 22:57:01 -0800 (PST) Received: from [10.72.112.128] ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa108c4dbsm8361835b3a.5.2026.01.18.22.56.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jan 2026 22:57:00 -0800 (PST) Message-ID: <232cbeeb-1a8c-4b09-9e72-50fc544864b1@redhat.com> Date: Mon, 19 Jan 2026 14:56:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/47] arm64: mpam: Add helpers to change a task or cpu's MPAM PARTID/PMG values To: Catalin Marinas , Ben Horgan Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com, baolin.wang@linux.alibaba.com, carl@os.amperecomputing.com, dave.martin@arm.com, david@kernel.org, dfustini@baylibre.com, fenghuay@nvidia.com, james.morse@arm.com, jonathan.cameron@huawei.com, kobak@nvidia.com, lcherian@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peternewman@google.com, punit.agrawal@oss.qualcomm.com, quic_jiles@quicinc.com, reinette.chatre@intel.com, rohit.mathew@arm.com, scott@os.amperecomputing.com, sdonthineni@nvidia.com, tan.shaopeng@fujitsu.com, xhao@linux.alibaba.com, will@kernel.org, corbet@lwn.net, maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, kvmarm@lists.linux.dev References: <20260112165914.4086692-1-ben.horgan@arm.com> <20260112165914.4086692-12-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/16/26 3:13 AM, Catalin Marinas wrote: > On Mon, Jan 12, 2026 at 04:58:38PM +0000, Ben Horgan wrote: >> +static inline void mpam_set_task_partid_pmg(struct task_struct *tsk, >> + u16 partid_d, u16 partid_i, >> + u8 pmg_d, u8 pmg_i) >> +{ >> +#ifdef CONFIG_ARM64_MPAM >> + u64 regval = __mpam_regval(partid_d, partid_i, pmg_d, pmg_i); >> + >> + WRITE_ONCE(task_thread_info(tsk)->mpam_partid_pmg, regval); >> +#endif >> +} > > Isn't this function, together with mpam_thread_switch(), in an enclosing > #ifdef already? > I think Catalin is correct that this ifdef inside mpam_set_task_partid_pmg() can be dropped. >> + >> static inline void mpam_thread_switch(struct task_struct *tsk) >> { >> u64 oldregval; >> -- >> 2.43.0 >> Thanks, Gavin