From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org, morten.rasmussen@arm.com,
quentin.perret@arm.com, Dietmar.Eggemann@arm.com
Subject: Re: [PATCH] sched/fair: Remove unneeded prototype of capacity_of()
Date: Mon, 28 Jan 2019 08:34:39 +0000 [thread overview]
Message-ID: <232cce1e-7fb5-c1fd-8171-ca4fc00171ba@arm.com> (raw)
In-Reply-To: <20190102135549.6929-1-valentin.schneider@arm.com>
Hi,
On 02/01/2019 13:55, Valentin Schneider wrote:
> The prototype of that function was already hoisted up in
>
> commit 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")
>
> but that seems to have been missed. Get rid of the extra prototype.
>
> Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
I had forgotten about that one... Ping.
> ---
> kernel/sched/fair.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 6483834f1278..6d653947a829 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5083,7 +5083,6 @@ static inline void hrtick_update(struct rq *rq)
>
> #ifdef CONFIG_SMP
> static inline unsigned long cpu_util(int cpu);
> -static unsigned long capacity_of(int cpu);
>
> static inline bool cpu_overutilized(int cpu)
> {
> --
> 2.20.1
>
prev parent reply other threads:[~2019-01-28 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 13:55 Valentin Schneider
2019-01-04 9:15 ` Quentin Perret
2019-01-28 8:34 ` Valentin Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=232cce1e-7fb5-c1fd-8171-ca4fc00171ba@arm.com \
--to=valentin.schneider@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=quentin.perret@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®