From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED0BC63797 for ; Tue, 17 Jan 2023 08:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236024AbjAQIU7 (ORCPT ); Tue, 17 Jan 2023 03:20:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235974AbjAQIUx (ORCPT ); Tue, 17 Jan 2023 03:20:53 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF76129E27 for ; Tue, 17 Jan 2023 00:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673943609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qYjsZAmItyxO/xUrcysAZG44bv1fujnhVpm9qnfE2C8=; b=X8GRkvlEQN83v/RY7hVIqHMJ9AhDD9xh8SwIuBs5vA02A4M0x9QPRHUegw72ekYiVFhY27 e23WmS+3HY82mX7j5ab0zcQYwRN4jSycWYS2xpF+cny2Q+urKkgCZwXOA2sVxtq2f28jCO Ywi7ld+kEepzp4cZJFtuSce5oCXXaeo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-uuAQjnpbN6SzClURILUZzA-1; Tue, 17 Jan 2023 03:20:03 -0500 X-MC-Unique: uuAQjnpbN6SzClURILUZzA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 44E603C10687; Tue, 17 Jan 2023 08:20:02 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CFD9175AD; Tue, 17 Jan 2023 08:20:00 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391053207.2311931.16398133457201442907.stgit@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Al Viro , Christoph Hellwig , John Hubbard , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 07/34] iov_iter: Add a function to extract a page list from an iterator MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2330482.1673943599.1@warthog.procyon.org.uk> Date: Tue, 17 Jan 2023 08:19:59 +0000 Message-ID: <2330483.1673943599@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: > > +ssize_t iov_iter_extract_pages(struct iov_iter *i, struct page ***pages, > > + size_t maxsize, unsigned int maxpages, > > + unsigned int gup_flags, size_t *offset0); > > This function isn't actually added in the current patch. Oh... It ended up in the wrong patch. > > +#define iov_iter_extract_mode(iter, gup_flags) \ > > + (user_backed_iter(iter) ? \ > > + (gup_flags & FOLL_BUF_MASK) == FOLL_SOURCE_BUF ? \ > > + FOLL_GET : FOLL_PIN : 0) > > And inline function would be nice here. I guess that would require > moving the FULL flags into mm_types.h, though. Yeah, the movement of FOLL_* flags is queued in a patch in akpm's tree. David