From: Andrew Lunn <andrew@lunn.ch>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russ.weight@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 8/9] dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller
Date: Sat, 18 Nov 2023 18:47:50 +0100 [thread overview]
Message-ID: <2332a2e2-740f-49a6-8bef-d90ed010a434@lunn.ch> (raw)
In-Reply-To: <6b39c522-1486-4e30-b958-b8a57104cede@linaro.org>
> > + ports-matrix:
> > + description: Port conversion matrix configuration
>
> I do not see such property defined anywhere. Your description should
> explain what the purpose is and what it is exactly. Currently you just
> repeat property name, so quite pointless.
I have to agree. You appear to have a device which can supply power to
48 RJ-45 connectors on the front panel? Which probably maps to 48
ports of a Ethernet switch. How do i use these properties described
here to say that eth42 connects to port 42 of the PSE?
> > + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> > + minItems: 1
> > + maxItems: 48
> > + items:
> > + items:
> > + - description: Logical port number
> > + minimum: 0
> > + maximum: 47
> > + - description: Physical port number A (0xff for undefined)
> > + oneOf:
> > + - minimum: 0
> > + maximum: 95
> > + - const: 0xff
> > + - description: Physical port number B (0xff for undefined)
It would be good to explain what Port A and B are. It might be obvious
to somebody who knows PSE, but i have no idea...
Andrew
next prev parent reply other threads:[~2023-11-18 17:48 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 14:01 [PATCH net-next 0/9] net: Add support for Power over Ethernet (PoE) Kory Maincent
2023-11-16 14:01 ` [PATCH net-next 1/9] net: pse-pd: Rectify and adapt the naming of admin_cotrol member of struct pse_control_config Kory Maincent
2023-11-16 14:01 ` [PATCH net-next 2/9] ethtool: Expand Ethernet Power Equipment with PoE alongside PoDL Kory Maincent
2023-11-18 17:38 ` Andrew Lunn
2023-11-20 10:09 ` Köry Maincent
2023-11-20 11:10 ` Oleksij Rempel
2023-11-20 18:00 ` Andrew Lunn
2023-11-20 20:42 ` Oleksij Rempel
2023-11-20 22:14 ` Andrew Lunn
2023-11-21 5:12 ` Oleksij Rempel
2023-11-21 10:02 ` Köry Maincent
2023-11-21 14:19 ` Andrew Lunn
2023-11-21 14:56 ` Köry Maincent
2023-11-16 14:01 ` [PATCH net-next 3/9] net: pse-pd: Introduce PSE types enumeration Kory Maincent
2023-11-24 16:35 ` Simon Horman
2023-11-16 14:01 ` [PATCH net-next 4/9] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface Kory Maincent
2023-11-16 14:01 ` [PATCH net-next 5/9] netlink: specs: Modify pse attribute prefix Kory Maincent
2023-11-18 23:57 ` Jakub Kicinski
2023-11-20 10:19 ` Köry Maincent
2023-11-20 16:53 ` Jakub Kicinski
2023-11-16 14:01 ` [PATCH net-next 6/9] netlink: specs: Expand the pse netlink command with PoE interface Kory Maincent
2023-11-19 0:01 ` Jakub Kicinski
2023-11-20 10:13 ` Köry Maincent
2023-11-16 14:01 ` [PATCH net-next 7/9] firmware_loader: Expand Firmware upload error codes Kory Maincent
2023-11-16 16:30 ` Luis Chamberlain
2023-11-16 16:37 ` Greg Kroah-Hartman
2023-11-16 17:44 ` Conor Dooley
2023-11-16 21:56 ` Andrew Lunn
2023-11-17 8:56 ` Köry Maincent
2023-11-16 14:01 ` [PATCH net-next 8/9] dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller Kory Maincent
2023-11-16 14:31 ` Krzysztof Kozlowski
2023-11-18 17:47 ` Andrew Lunn [this message]
2023-11-16 14:01 ` [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver Kory Maincent
2023-11-16 14:29 ` Krzysztof Kozlowski
2023-11-16 14:59 ` Köry Maincent
2023-11-16 22:38 ` Andrew Lunn
2023-11-17 11:15 ` Köry Maincent
2023-11-16 22:41 ` Andrew Lunn
2023-11-17 11:22 ` Köry Maincent
2023-11-17 14:50 ` Andrew Lunn
2023-11-16 22:54 ` Andrew Lunn
2023-11-22 16:11 ` Köry Maincent
2023-11-22 16:54 ` Andrew Lunn
2023-11-22 17:16 ` Köry Maincent
2023-11-22 17:49 ` Andrew Lunn
2023-11-18 18:54 ` Andrew Lunn
2023-11-22 16:48 ` Köry Maincent
2023-11-22 17:11 ` Andrew Lunn
2023-11-27 17:28 ` Köry Maincent
2023-11-24 16:30 ` Simon Horman
2023-11-18 23:59 ` [PATCH net-next 0/9] net: Add support for Power over Ethernet (PoE) Jakub Kicinski
2023-11-20 9:22 ` Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2332a2e2-740f-49a6-8bef-d90ed010a434@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kory.maincent@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=russ.weight@linux.dev \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®