Re: [PATCH] block, bfq: remove redundant __GFP_NOWARN

[Yu Kuai <yukuai1@huaweicloud.com>]

Hi,

在 2025/08/09 22:22, Qianfeng Rong 写道:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
> GFP_NOWAIT implicitly include __GFP_NOWARN.
> 
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
> `GFP_NOWAIT | __GFP_NOWARN`) is now redundant.  Let's clean up these
> redundant flags across subsystems.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
>   block/bfq-iosched.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 3bf76902f07f..db0ae65186ec 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -5848,7 +5848,7 @@ static struct bfq_queue *bfq_get_queue(struct bfq_data *bfqd,
>   	}
>   
>   	bfqq = kmem_cache_alloc_node(bfq_pool,
> -				     GFP_NOWAIT | __GFP_ZERO | __GFP_NOWARN,
> +				     GFP_NOWAIT | __GFP_ZERO,
Can you also combine this line with the one above?

Otherwise LGTM. Feel free to add:

Reviewed-by: Yu Kuai <yukuai3@huawei.com>

>   				     bfqd->queue->node);
>   
>   	if (bfqq) {
>