From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11022137.outbound.protection.outlook.com [40.107.209.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6B6212554 for ; Fri, 3 Apr 2026 07:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.137 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775201015; cv=fail; b=QFNq/f3i9oTkVuVU3cLItXdTQpXrMqkpJgFg53nMYTa5x89fe5XlBQNEU/PgxMduZjNxuA6DP5QIm/yNnlA0fD499dLpfsIEIQzDJx0bS9oocmnxFbQpjQJHpdLTVsdzoZAG+xxSpKGqsyO4JztHykPH5YHsvy9Y961KQ7JStVg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775201015; c=relaxed/simple; bh=0GMnLZ58SQ04r71+S9hNpeQbQkQzbc/WSAqui5/PB2E=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=DuZHy9HDDOj8GHIbwWfcJgk+T4LkN0szy64g5UGYdoWqxsQKFjum3lhqBd1t9Tq7GSX7eSvHiVKuf56NKIckCO4ggzWR24G1YjdVd+0AwbKto8H5Eh59NI9Dmpg9McJN24p1Hpfi2h10HFWAkxMMIRMFxv3VyM/KJTMIWgO529Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=vqwR1E4H; arc=fail smtp.client-ip=40.107.209.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="vqwR1E4H" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KWQMajdr5hn4k4HJMu54fFIl2SPoByop4iCEn0AyhK0fxdioHFa+Nq6tR9H5BhuPuJKYzSmXtjuHANsB25NScsvOvKh8dE5xOJIbQtEkW6/gezwG6eAnF7GUR8Rm5wUpt0vUTy+TfhG8SlT6C1ql/4E0ZH/T7xfJXxSkCweiS/u6Jr/KWq4BTCjsG5XKRxb2srJG8DCKlcR0miRHVCZccFHVNNPGmmocVim/D53HCUrmNCBDcrXlvbsurEX9yLaR6qxCfBh4JMFhLWMRV1ZsdlwSLWOM7YMnWe4l10hWP/R48Wiw3+XAXyD0C0jB3uKlqnWCRD03dCh7w+UjeM8cNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3N37bQns8MzsnZd+NLn5TOccNrf5RTnse3t+IzwUvfA=; b=P9KRdB179Xp0T9wlXZHiCckZ3QF6zzxDMBFq/lsUO6LBYyKTU4E3cYR9DN3fecAwsml43iUpjILc+gfX1z68aym2L/CK7ccXAQrShY3Q7MSsR2K+2acDJZ6O5LjKH4V9LK0fEEN9RUVYFGBETfM2rzMhLEJQVPeDHsDUb34M3a2mOIS9nTkOieCc41iT90nDbIQWRytSzzpoZiprJUcro+HfaRvvvA//GO1o3Fr+JOx0hhS3OgDu3Nyg6lX5AaKImPaT2/6k0yXe/GRNhd2fN7yYfLrPb9ObFLR9nck8HxIzmv6RXP+aFOaxnaOs07/bfxCgNASQRNDbj8I3OATKVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3N37bQns8MzsnZd+NLn5TOccNrf5RTnse3t+IzwUvfA=; b=vqwR1E4H7NTvR2Le3idvx8VOVmCBAt8nIxenUWNXaPvZwkX+5N9NAwgHFmMt1s//iMKef6rEk3myyO+WtFkZGPU7UG7iZeDZAWR3InARC4FDl8puiwXUc3s7z61GS7CTAyP0/xxL59Fbe9MA3fXiO43oSwQwXN4kfVya675BgWU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from LV5PR01MB9418.prod.exchangelabs.com (2603:10b6:408:307::22) by SN4PR01MB7519.prod.exchangelabs.com (2603:10b6:806:206::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Fri, 3 Apr 2026 07:23:32 +0000 Received: from LV5PR01MB9418.prod.exchangelabs.com ([fe80::7c7e:35d5:73d6:89f6]) by LV5PR01MB9418.prod.exchangelabs.com ([fe80::7c7e:35d5:73d6:89f6%4]) with mapi id 15.20.9769.018; Fri, 3 Apr 2026 07:23:32 +0000 Message-ID: <233889df-38ae-4878-afe9-5d23d74be00f@os.amperecomputing.com> Date: Fri, 3 Apr 2026 14:23:20 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [Openipmi-developer] [PATCH 1/5] ipmi: ssif_bmc: cancel response timer on remove To: corey@minyard.net, Jian Zhang Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20260402110435.3589408-1-zhangjian.3032@bytedance.com> Content-Language: en-CA From: Quan Nguyen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR06CA0183.apcprd06.prod.outlook.com (2603:1096:4:1::15) To LV5PR01MB9418.prod.exchangelabs.com (2603:10b6:408:307::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV5PR01MB9418:EE_|SN4PR01MB7519:EE_ X-MS-Office365-Filtering-Correlation-Id: bbe0eb21-65e9-4593-c1db-08de9151e8cf X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|55112099003|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: dlSN+YRUEEpcpZlTY+Fxx7zOzeNaRVdbBHk1KcYCPue0aVEChaS5Vd6USMiccU+ZKvSvEsh6jI6C3EuYSWK3bdJScbXu5D7mzEs2lqayv/El4OHVemRM4SRd+0pZAzLaWbXOegFGFGHtVrUzC8WnuZZjgclw6A/LnZItdDV424fwlH7DfsD/IK6jeJeJ3NKjxxNwutnl9LmKCB8ViW+lEXKDCWZRRutzLhv7RS6w3jjRIh85Z5rHDwdSbCSvQafzh6Z8lRsQSiypzfsSXMkdfrF/9vqMHUoFyw88PsTnILcd19zvauDlCDVGWdczSCesL12bSDN85/0RaQUHSjLneiCZw8kQ1kOtqmWr6JeJ4GqJl5XWQ1jim8b5/n+p7mfRRW+80VOROgkQkFJArgSquwxvo+eCNcYFL0RNlsF+EXo3BYuRNAEwqbLMxlL6DPAPvkfrvNrIVhgvZYMBrCzjcfAXBPGJ/iCgW0pB4uVUoOYV9mAaOqe8GNPIOqrZKdSCDAH7rqUnzYkm+0i3bbCjhsZE7j2vHHkqyvBOPncAT53U9uDUPv+LMWACbMve9Cd80lAb2Wi+/eiPymNVrgZB/CEGGHgee+i7hTZiaQ/3wIkcRqHS0YMpFuBAL7ZTSKePC0F2Vk6DMIpPJpojaV1tFzrmIz//xCeVBMjfmBykhGTmhHXQGi+HVeqG/5VoNBcznPZu1tAaW9SrglsUMGZY9kTL2tFb2AAAqNWOFQ6YR2w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV5PR01MB9418.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(55112099003)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dE12U29uSi9PL2V1WDl0NGtNL2E1QUZ1ZXRoZ2Mvam82NVVhaDRIL1ZKNmJr?= =?utf-8?B?WW51dUhJcXF3TzVSRXRIcTRUZHBCNFBUUTRxenpwQnU0b2NNTFk3WEZzTFRK?= =?utf-8?B?Qi9yc0p6NTBTUTVicDhCUVZpSTVQMGo0S0tHNTk4Ry9kM0FLTDR1T3BRMDdw?= =?utf-8?B?TWpUK3Vmb0tCeng1T0RleFU3RUxMUlhzNEFEZ2FGNVFFT09KQ1BlM1FJNG1J?= =?utf-8?B?Q3lMY3ZuR01QRlhramdWTnN0MU9HUjZFSm40UGNZWjVRSWhxbkdvMG9WNU5E?= =?utf-8?B?RTNteFBndkgwK3NLRFJaLzc4K0pBRHVJcjlRRVVNN25XdVhWb3NuNWRGVU93?= =?utf-8?B?dGl2Q25hZUR1YTJrcFFoZFBwMGdFSjAyLzZPNE1SS2MxaElOSzVYbWNEeVUr?= =?utf-8?B?MFliNG0yN0JKVHBvZjByQ3JHK1dwTzA0VjJ0Nk1mM1lXa003OURLRXRscWRl?= =?utf-8?B?S2hxaVRzK3NKNDBJVDBPZWU4aU45ajNDZTRVTjRuY3hQdVFNRUMvYkkvL2hk?= =?utf-8?B?aXZMNitEeEJETk5UT016Tm9PTEdhYWNUckhlUDMzSHovd2p2a1Naa09FZ04y?= =?utf-8?B?cVg0SEpDQXFxWUJOSnNFQzNCczhTa0plUjBEVHlFRW54SFhoSGpjd2lqaGsv?= =?utf-8?B?R1ZjL09LcWJSR3ExdXJMTGRtTVkzd2xWaVBUcUZqcjY0R3llc0FvTGM2T0lC?= =?utf-8?B?bUpTczVyQTVrTWtEU3NtZVZtQTVVek9TTXYzalJCNzdySjRuWVhJRHUvV2pa?= =?utf-8?B?VDVtU1lQNWJ5cmpINFdHV1VEcnh1RklIUDVEeUJmUFhBeFNPYVBqTVhGanI2?= =?utf-8?B?dzQ1QlpLb3FCQ1NTZHpBL0tmd1Y5bzhNdk1qWlV0Ynh2UDZKS2hwb2Z2VXFB?= =?utf-8?B?MUlpcXQ1enVac0pEcUt6K1liMW5jekJHdXQyT3EyTm9mdWpicWNncnBnSHEz?= =?utf-8?B?NmxvcGtqMnFjTHFLdnF3bkRHdGQrUUZjR21zQ1Y5NGk1OVQrOTh2Q0hnQ2E0?= =?utf-8?B?Z3QrUFZBYVA0YXgwOTR0UXVVeGZVS1ZZTnBBY0lleG1MNFB0TmZGYjJpSGw5?= =?utf-8?B?VlZsalVzODNJdHF1NkxZcmJ2L3hWZC9WRmc3N0tlaVRIZ1MzTWNBbDJVOVRL?= =?utf-8?B?alVpa0xmMnBpWDlPUDJXT3J2Q1MvSnlPYThBSjI5QVZqb0s4R2k4ODdHQjBR?= =?utf-8?B?T0JBdW9SZlg1ZHBGc3NUZ1psT3lQTjRIUU13bGlUaE5OWVhBVG1nVzd5eEV1?= =?utf-8?B?eEs4MWZQclJtR0tmN0FKa3F5RGtHdkQvZHhPZ1RYemRsbnRjMHJzTTJoUTVD?= =?utf-8?B?UTZ3S0FENnJoSTFaTFY3TTU1UUhqblNrNm9xa3p6MElzVVBHalFHQUw0UEpr?= =?utf-8?B?dUdkK0dvbE9MQjJtWFNkb05uUFRhSXY5b0Z4MEVJTklneHlYU0hkcWsxVkR5?= =?utf-8?B?ek5mYlpyazFXVVRpcW5ZME1TWUxEMldhWkk0NEVkWHpKbnBHaW1Rd2ZUeTBo?= =?utf-8?B?YXlvVHAzRExheFBkc3IzNnIyTloyRDlMVG5BUnRPM3lodys1SGR5T1laVFJX?= =?utf-8?B?STdnZElkSTZ5OSt2bEs1MWU1bGNjYTl5UjMxL2habS8rNkdUWGJjdkRHSXlJ?= =?utf-8?B?VlNTejFqYlRLV2hQclNreHBOK05vYUxGeE9HODlvSm42SkhrRHpRTCttU3ph?= =?utf-8?B?WFd2SnUrRHZTdmc1S2tieHdEd2tyclZSaUxyZDkrYzE5ZlowUEFrN2hoZ1lh?= =?utf-8?B?bmRmbWZGNnVMcTV0eDU2OWNnZWcyQVp1Ym8vRS8vaUNNSkZ4SWVMYXM3L0pV?= =?utf-8?B?L3FDVDBzbXNBSVJyc2FiVlhuZEk2QzMwenhNb2FXeDkzYUVQZ3dJbzIyRVZ6?= =?utf-8?B?OXZsVnEzYjhlNWQwUVBXc1FHOUQvZC9zWDFKRUhLVDhxejZpMjZOM0diY01K?= =?utf-8?B?OU9TUGFCbEhrR3NNeGMrNmZoV0kzeU5UVVAzWFdLOG0raU1Pd0xmMDB5Z1dz?= =?utf-8?B?TGtaQzk1U1NIRUdEdERRbmtudm9Cdi90M3hhWE1uZHZEYWk2aEV3WS9kVUpt?= =?utf-8?B?QTZQdzBkZXl5YUxOaWRFRktTcytySzJyZ0M5UFpkR25QaTZZWnpGUGpEWHJN?= =?utf-8?B?ZTY2emRycG5YcDJHbTlQdURpVFJDYVdrVFZFam5nUmhZRTRrZ21NZnlwREJK?= =?utf-8?B?QkVKQkNFRThNYk5MRElsaTJ4MEJQQk1manFteWt3WWlsZFc3L2ZpU0NnNGtl?= =?utf-8?B?R2lxVXJqc0J3T3dZWEg5R2JjVldManpHWlJqRW9zQkZMQlloSVBNUGtQRUVG?= =?utf-8?B?UDhOd1pQZm1pTVpiUHQ4dTRiMEQrZEZEalM2eHhqOXh6UG9xQTVnL1lMWDdP?= =?utf-8?Q?9wCYOd+pDuC4X8G4=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbe0eb21-65e9-4593-c1db-08de9151e8cf X-MS-Exchange-CrossTenant-AuthSource: LV5PR01MB9418.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2026 07:23:32.0778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YsCj1/f62hXyAHI1Dhp6HfEH8rs4C/6hPQ95QDrYo2XamHt8fLIZ4TBgjSrgT3faQVN4lYmb+2EIx5n3Pr7Xv18HIoYhPjZgp9PMu4A3yUo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR01MB7519 On 2/4/26 22:42, Corey Minyard wrote: > On Thu, Apr 02, 2026 at 07:04:31PM +0800, Jian Zhang via Openipmi-developer wrote: >> The response timer can stay armed across device teardown. If it fires after >> remove, the callback dereferences the SSIF context and the i2c client after >> teardown has started. >> >> Cancel the timer in remove so the callback cannot run after the device is >> unregistered. > > This whole series looks good to me, and I have added it to my next tree. > I'd like to hear from Quan, though. > The whole series looks good to me too. Just a little concern on the 3/5 part as we have not yet encountered. Thanks for the patches -- Quan