From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95DD224167A; Mon, 20 Oct 2025 10:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760956379; cv=none; b=tvTuXfwsER+78Ipx8B+wBNxRy5vNryPNCRU99DMFevd+Gdg0AhqeN5sO0whUjyX+gP3PcVxaMciBl6YuHV29DYy8BJyktk8LbMwT03fVRPiRLZTSuyxvPDTWq8HplWuCwmZdarD/q2fFPZYvPD4c7In88fSg7SjNOSiydSrR6PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760956379; c=relaxed/simple; bh=sKLQ2d58/dXav4cTRenoQbd/b+gVPHXCpdfcPSSetAI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ut+9ur99pEzdq7nvwonHuOaTKxWYo6l2a/Zm3mw8w78iC1V4IwBvc7/5BcG37ctgH9zGbIrTWAhhLo8wBKp3bxZ9Ay9SfYHdRaMXK+3GU62IiqORKs1Yknxk7UYG//rL26ouQUQGvwztVmCmHciLQh/DFU8WEQi2o3480rDiGlE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C576E1063; Mon, 20 Oct 2025 03:32:48 -0700 (PDT) Received: from [10.57.65.147] (unknown [10.57.65.147]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 924903F63F; Mon, 20 Oct 2025 03:32:48 -0700 (PDT) Message-ID: <2338a99c-665c-4545-accb-c9ebffef45fa@arm.com> Date: Mon, 20 Oct 2025 12:32:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/13] mm: introduce generic lazy_mmu helpers To: Alexander Gordeev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andreas Larsson , Andrew Morton , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , David Hildenbrand , "David S. Miller" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org References: <20251015082727.2395128-1-kevin.brodsky@arm.com> <20251015082727.2395128-7-kevin.brodsky@arm.com> <55f8b155-5468-43fc-b6fc-f509f4becd5b-agordeev@linux.ibm.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <55f8b155-5468-43fc-b6fc-f509f4becd5b-agordeev@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/10/2025 17:54, Alexander Gordeev wrote: > On Wed, Oct 15, 2025 at 09:27:20AM +0100, Kevin Brodsky wrote: > > Hi Kevin, > > ... >> * lazy_mmu_mode_pause() ... lazy_mmu_mode_resume() >> This is for situations where the mode is temporarily disabled >> by first calling pause() and then resume() (e.g. to prevent any >> batching from occurring in a critical section). > ... >> +static inline void lazy_mmu_mode_pause(void) >> +{ >> + arch_leave_lazy_mmu_mode(); > I think it should have been arch_pause_lazy_mmu_mode(), wich defaults > to arch_leave_lazy_mmu_mode(), as we discussed in v2: > > https://lore.kernel.org/linux-mm/d407a381-099b-4ec6-a20e-aeff4f3d750f@arm.com/#t See my comment on patch 7 - these new arch callbacks can easily be introduced later, I don't see much point in introducing them now if they default to leave/enter on every architecture. - Kevin