From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 273F63FB7FC for ; Fri, 31 Jul 2026 11:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785497826; cv=none; b=fsM7EaaRZWFRU+TNvemVi9cTNuzo3Zgj8qy9CCyvTq++kAYbsjUcPmaLJsRgSroVX1c0z2kxNvktAsLtex+qS34rvkcjN/7V38hFz9eFjZp2AdZ6oVxdKq2RGe78FykEJyqtAuEAEDXB5itbsOVNN7O2zHsW/V1D5m1vpGZiMKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785497826; c=relaxed/simple; bh=vV2SkM0yNJjd731dpBt8g2sTf775LbK3wbwLSPbDh/g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Si87xFgkCxyb/v26r1hu+PwMYthpgS97Vx3cjsUupBkuYhUKYPCjmcG6bF36tFTrHLUbohIr5S7h4wJ2mn+s2tZ/hw2+p3tuqPIOrTtGqh+Zr4feXwdRpi7lLBeI6gnb3JOq4xKf1tNGa+uCDzmU7p3wnGuBB5wtdV1inoNa+yE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S+qmdY0y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X5j27Gid; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S+qmdY0y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X5j27Gid" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VBMDJ54001712 for ; Fri, 31 Jul 2026 11:37:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SV79Lg7diCi5lX/hgaJG1o94pxC1WlFKHg1QeOlGtrc=; b=S+qmdY0yYBo3aTnR syEnKXb89wqsWwXTqctsIQwqiWybT+fzS93WyvksXRG82GFGl+WSpkU3QVknDELL UyQzANkUHHzt+0nms9DzOewIt+V5W7Kf7SxfTMGV/IhwbRa0NicGfsKgxNOzrLbL RbOROJJD1WFaR1QdJqdQPd3qvjBrY4BkZBddgvBo9M03+xyvwlsEXYNUPMeY29HO yGhjcM1U6o+isOz8rOv0JkF7CAubSmlMPij53dxGtCz/Ybf6wIecXhjiBkOFBGiN XEWkd2rYAHjgnzuZtQ2BBWyNAEw6GnAJ3I8RJbw+/1H6qWnbaAGKVbGZBlUxSCYV K6KXdg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frtpr82r7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 11:37:02 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-901fdbfc3abso4039886d6.3 for ; Fri, 31 Jul 2026 04:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785497822; x=1786102622; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SV79Lg7diCi5lX/hgaJG1o94pxC1WlFKHg1QeOlGtrc=; b=X5j27Gid1T4fo5yeSd7Q7iwD8idKDnMX0keGwvdXy3aPFQc+2+vaHawuBgYMw+H97K gxMncf/PYebESNhHRwb9TdTcjvDRuFEg1FPPl5kBWPLMBtK8VLQW2vGevRUvb5pxa75p A3c3+v+zUrYg12KCny0D0T+hli1B2ZK1FBhzXtnnW1PAlKR7iCJU/bNlfSyzr/nI+yl/ NQmllpI6vdsbNjf4N5Yu3rtda7Ig538b3qTi6xdIpJ16VQp8B1AxDMmrlJTnQ06WYatJ yHYJmu3qP/smsaSiUoyKf1rDvdWOJrtF6Mi9jJkewgYGCMMPWwsAx00KTOFzYyLe4cxF 9O/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785497822; x=1786102622; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SV79Lg7diCi5lX/hgaJG1o94pxC1WlFKHg1QeOlGtrc=; b=jV6acppzAu3QUNuDqkceX//cZDn7KB+4IT/Y02GmaM5pNmBPojl0nHYmV9niRlqO1h YNIpqX6KFDmr2DhWSW49CZu6BLd0U80JbrOkpoOf0ZfT6AGyuhK5Yuurpbpfvld8VBWc YZXwOJI+xGBwfHMf6CkqNfjGqYtNay5bQ52Rnu2NZrdEtEA8nYmxMqmkG7kpDRaKWXM+ XFG87RAZBQdCSEEjm4+dpNHgkPGAPbqSnl4Kgn+n6J+G+kymYkxkaOgW8jqngRoAyftI s3RCDSol19A5Acx3KXIew5d6PnSHB/qTgG9w5EnWcyq7oxewZStl51SXduidQg1EtY02 TW4w== X-Forwarded-Encrypted: i=1; AHgh+Ro9y3gEffeqd1Qkp4zfgAgtnX0fHoxEC0+NbRphrNQK/dXQtOMuE/HBwjPw2Q/IYHbSq4pWwdYzjY3fW/s=@vger.kernel.org X-Gm-Message-State: AOJu0Yys+bd9Z9OB1oT7q8PZLY1B77/c7rFl7vxnBIxn8qNkGF0ORSlm 2vQXn76wiwARUG4Cwtt6LJ3Y7wVI+jOBuhcThdNQoiAXCixL5lEexKDKnqu15Twqs8wHxW82OgZ 1YtLmka+LbVzSq4H9a1jNjft+hdTSHFONziTC+YSq/xIOdhNe2U22rczN9gPb9/mcRd8= X-Gm-Gg: AR+sD10aB7cw7HrWLK+lbXspQLNqTEAp+bzBFLVs+Dv4H5gP47f5dAtV0ieuurLcyEd X7tQ18uX561g3vBwdTrPFU5dkAa8GXNpzSxD4kujl5YqoKnkVaZZtV5vDm8zjERNW55FYFXiFp1 f8P0OiBwm7IbwE0KF0FI5d9B3Tsy2pSFc/VolutqLtvdq7bD5kvLrMcNRvY99o4h16rcGpEpXLL o4waJm3vpRcE6DgqxVeN5zWfJLaojwOFAHo/pVDk24FoG4KjxZNZyRmIIPUReYVp7XhKjYLvK0S 5c6bAvCKlG1VcXtk/jJLE0vMnlBWRmhRQCuPSH2xeFAc/irExfqvVjPEB5d8jh0kw7k8qPbjJEl cGzkJdaYPL0eSQrNZGkLlSNt9 X-Received: by 2002:a05:620a:2684:b0:92b:55d5:ba3 with SMTP id af79cd13be357-934963bf85cmr199625885a.0.1785497821878; Fri, 31 Jul 2026 04:37:01 -0700 (PDT) X-Received: by 2002:a05:620a:2684:b0:92b:55d5:ba3 with SMTP id af79cd13be357-934963bf85cmr199622985a.0.1785497821095; Fri, 31 Jul 2026 04:37:01 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c93a87sm125439266b.18.2026.07.31.04.36.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 04:37:00 -0700 (PDT) Message-ID: <234116c1-5e19-4365-9b3b-0dd1ce64d972@oss.qualcomm.com> Date: Fri, 31 Jul 2026 13:36:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] media: iris: fail firmware boot on invalid uc_region To: Dmitry Baryshkov , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Vedang Nagar Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260731-iris-fixes-v2-0-94c002016a09@oss.qualcomm.com> <20260731-iris-fixes-v2-1-94c002016a09@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260731-iris-fixes-v2-1-94c002016a09@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=LORWhpW9 c=1 sm=1 tr=0 ts=6a6c88de cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=M_9emyDH5AVLG-PN9cMA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: NvHZ-2NP8gQSAe6iA2Ba3adVyENQ1afa X-Proofpoint-ORIG-GUID: NvHZ-2NP8gQSAe6iA2Ba3adVyENQ1afa X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA4OCBTYWx0ZWRfX7LScbzaqJkkE n/lYZbkH1KGZRnaOB28cbku2zw8qYsIS0PS3ljYzOeEJYufohCVctiekHeNOaHoccONfDrTDNQY aYG1zInHQsUagKNW6Es84YW/ZR88vI4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA4OCBTYWx0ZWRfXzvCiquXINZum wOgrg36MJ4FpoiRlO/uxqACb5jgrFCW5u9/D4/Eb6dzRdVdGBuGtiwADQk1HtIEbdmJl0IiXCuv nFemhlk81Ct7vpeTkikGinrYe+Y7XCdpDHOY3vkz+Uns8pMdeyqhVeNExaMUhfQlO0of5VlN3P+ T6iw6plBjGPwUexIJ2vH3d+Ku3EmNQnCkAFBoJ+KwdSOTRJJMIZVSOlF9n2Woc4kAuDMC+Yzf9n Fgf2DGH820Ba+gPjQxXEH0sJZFKAEfaWSaOvE4P18Ru7hs74sQfR4l+e7Julu/cQxFDRK6tlRxm 74UAAAsTVP6nId4Z47IX4znx2oEnatcDtrI5mz0V2R2KdRFMNvYZt7LudUlPoTnQOjWa9uDrGmm fI7KiQ0IUsCH6WlEwc7ssDL2rm8UCQN/tb4RvyDhAWnCSLLxEwHvzscy3PHu4a1WNC4ZKW0v+hj MpROIHBUh0y683ycUyA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 adultscore=0 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310088 On 7/31/26 2:31 AM, Dmitry Baryshkov wrote: > iris_vpu_boot_firmware() polls CTRL_STATUS while the firmware boots. When > the hardware reports an invalid uc_region setting, the poll loop breaks > early with count still below max_tries. The following timeout check > (count >= max_tries) is therefore false, so the function skips the error > return and falls through to return 0, reporting a successful boot. The > caller then enables host interrupts and proceeds to use firmware that > never came up, which can lead to unhandled timeouts or hardware hangs. > > Return an error directly from the uc_region error path instead of breaking > out of the loop and reporting success. > > Fixes: abf5bac63f68 ("media: iris: implement the boot sequence of the firmware") > Assisted-by: Claude:claude-opus-4-8 > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad