From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754763AbbCCHDh (ORCPT ); Tue, 3 Mar 2015 02:03:37 -0500 Received: from senator.holtmann.net ([87.106.208.187]:48545 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbbCCHDf (ORCPT ); Tue, 3 Mar 2015 02:03:35 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: [PATCH net-next 10/14] bluetooth: Use eth__addr instead of memset From: Marcel Holtmann In-Reply-To: <3e4a2efa6cbc9bea479bd3d8460ea56dda128faf.1425354528.git.joe@perches.com> Date: Mon, 2 Mar 2015 23:04:27 -0800 Cc: netdev , LKML , "Gustavo F. Padovan" , Johan Hedberg , "David S. Miller" , linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <235052A1-0253-41FB-B381-FBC8B312ADE6@holtmann.org> References: <3e4a2efa6cbc9bea479bd3d8460ea56dda128faf.1425354528.git.joe@perches.com> To: Joe Perches X-Mailer: Apple Mail (2.2070.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, > Use the built-in function instead of memset. > > Signed-off-by: Joe Perches > --- > net/bluetooth/bnep/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bluetooth/bnep/netdev.c b/net/bluetooth/bnep/netdev.c > index 4b488ec..6ceb5d3 100644 > --- a/net/bluetooth/bnep/netdev.c > +++ b/net/bluetooth/bnep/netdev.c > @@ -218,7 +218,7 @@ static const struct net_device_ops bnep_netdev_ops = { > void bnep_net_setup(struct net_device *dev) > { > > - memset(dev->broadcast, 0xff, ETH_ALEN); > + eth_broadcast_addr(dev->broadcast); > dev->addr_len = ETH_ALEN; Acked-by: Marcel Holtmann Regards Marcel