From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758922AbaGOMK1 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Jul 2014 08:10:27 -0400
Received: from v094114.home.net.pl ([79.96.170.134]:57280 "HELO
	v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1758321AbaGOMK0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Jul 2014 08:10:26 -0400
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpuidle: fix permission for driver name sysfs node
Date: Tue, 15 Jul 2014 14:28:39 +0200
Message-ID: <2350821.Beygah9hYC@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAHu9=sPxG49pCn10WTErHEV3ZZSF70+7ekZWJ-1+dd3Df8i8Wg@mail.gmail.com>
References: <1405171762-31119-1-git-send-email-meraj.enigma@gmail.com> <CAHu9=sPxG49pCn10WTErHEV3ZZSF70+7ekZWJ-1+dd3Df8i8Wg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, July 15, 2014 11:16:40 AM Mohammad Merajul Islam Molla wrote:
> Hi Rafael/Daniel,
> 
> Did you get a chance to review the patch?

We will review it.  Why is this urgent?

Rafael


> On Sat, Jul 12, 2014 at 7:29 PM, Mohammad Merajul Islam Molla
> <meraj.enigma@gmail.com> wrote:
> > cpuidle driver name sysfs node is read-only. So permission should be 0444.
> >
> > Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
> > ---
> >  drivers/cpuidle/sysfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> > index efe2f17..97c5903 100644
> > --- a/drivers/cpuidle/sysfs.c
> > +++ b/drivers/cpuidle/sysfs.c
> > @@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
> >
> >  #define define_one_driver_ro(_name, show)                       \
> >         static struct cpuidle_driver_attr attr_driver_##_name = \
> > -               __ATTR(_name, 0644, show, NULL)
> > +               __ATTR(_name, 0444, show, NULL)
> >
> >  struct cpuidle_driver_kobj {
> >         struct cpuidle_driver *drv;
> > --
> > 1.9.1
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.