From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757581AbdLQRhs (ORCPT ); Sun, 17 Dec 2017 12:37:48 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:63228 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757425AbdLQRhq (ORCPT ); Sun, 17 Dec 2017 12:37:46 -0500 From: "Rafael J. Wysocki" To: Jean Delvare , Vasyl Gomonovych , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman Subject: Re: [PATCH] PNP: pnpbios: Use PTR_ERR_OR_ZERO() Date: Sun, 17 Dec 2017 18:36:58 +0100 Message-ID: <2350906.AG48QEUOht@aspire.rjw.lan> In-Reply-To: <20171129215523.47246478@endymion> References: <1511972460-25499-1-git-send-email-gomonovych@gmail.com> <20171129215523.47246478@endymion> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, November 29, 2017 9:55:23 PM CET Jean Delvare wrote: > On Wed, 29 Nov 2017 17:20:57 +0100, Vasyl Gomonovych wrote: > > Fix ptr_ret.cocci warnings: > > drivers/pnp/pnpbios/core.c:584:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > > > Signed-off-by: Vasyl Gomonovych > > --- > > drivers/pnp/pnpbios/core.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c > > index e681140b85d8..077f334fdbae 100644 > > --- a/drivers/pnp/pnpbios/core.c > > +++ b/drivers/pnp/pnpbios/core.c > > @@ -581,10 +581,7 @@ static int __init pnpbios_thread_init(void) > > > > init_completion(&unload_sem); > > task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd"); > > - if (IS_ERR(task)) > > - return PTR_ERR(task); > > - > > - return 0; > > + return PTR_ERR_OR_ZERO(task); > > } > > > > /* Start the kernel thread later: */ > > Looks good to me. > > Reviewed-by: Jean Delvare > > Applied, thanks!