From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions
Date: Mon, 04 May 2015 23:30:33 +0200 [thread overview]
Message-ID: <2355892.05HhS4M0WH@vostro.rjw.lan> (raw)
In-Reply-To: <1430582481-31606-1-git-send-email-fabf@skynet.be>
On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote:
> EXPORT macro must be placed directly after functions.
> See Documentation/CodingStyle Chapter 6
Well, why is this change an improvement?
Yes, it makes an old file follow the new(er) Documentation/CodingStyl,
but what exactly is the benefit?
Mind you, there are more files with EXPORT_SYMBOL(_GPL) at the end.
Are you going to hunt for them now or something?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-05-04 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 16:01 Fabian Frederick
2015-05-04 21:30 ` Rafael J. Wysocki [this message]
2015-05-05 17:39 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2355892.05HhS4M0WH@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®