From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E84C271A9D for ; Wed, 10 Dec 2025 15:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765382182; cv=none; b=SiIyf7w7zKJJhjfCR+yBDK01iZ7rHaFqFchQR0e6vOBDGmMUHwPoYIUZ10swE7F3heyOsVc/s+wfuOnY0nBNz1767aD0MaqaXQ9UT7Z7F0MSgBsq6v757ulrOP5xzRen9yTgg5XZT8Giqg6n/B/KoYnZq/11+jdtHhwsZL2BW/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765382182; c=relaxed/simple; bh=ptFGaneCWeUbL/tGg+mDVY6nszCKcLCRphTgND14Qvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BlnCb/vwKg0F+2mYizYvUsEixGaA5T0JfXJBfgIpNO6/EgTkM4R/M01W9pLNlpRR1aIbhBkg/gVsILvIuCUEgbSMVTLEFYTgRu7RwQbvGBo9+0XR6wiCqdYr3Ff4RN+QfVrBXTIZlaU4bCMrwZnOdgaqujjjkDF8XPw87+6oXeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h0Y9HVXQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z4HHq5sQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h0Y9HVXQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z4HHq5sQ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BAASfcl1802737 for ; Wed, 10 Dec 2025 15:56:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +OGRmQE+ixhep3xbt9u4H6AZAUyykWLVpStmzWh+KI4=; b=h0Y9HVXQToj3BazK 5uJkJpEJdpqdA2BGQlZVhLHE8iOl/pgQXLp2CPgm08cBXSn2KLL/Rj8TV/hciSxA OZt14d2EKmo2MROJ77g8YiDoJ7mMrbZCU1+lWnWzmkWBcIMhvQSxIYD/zDAKHHXk Z/4ppk8L0KbRXuy3/gP47vU5lHnawSrDThiG5qRa+Yh74cfIzYaHhDeseXNHH72Y x1p/smVdxvg65gH6BK1Peu2HVC0VszN9FAI9wdYbhj98nxTpqm6VzKDjfIt0FUhp fU6mRyMzC2cQd2iJTdcoe5ILkwspZ+btjOG0Kmwkge2SPuiwuxJe0M1k0gQkqr7Q xvyWnA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ay753s04v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 15:56:19 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297e1cf9aedso26475ad.2 for ; Wed, 10 Dec 2025 07:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765382178; x=1765986978; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+OGRmQE+ixhep3xbt9u4H6AZAUyykWLVpStmzWh+KI4=; b=Z4HHq5sQ1pJmFKFle1Ep5KAB5rrVtLQ/JEaMzKMSwqYuPswAljTFLDBnZUILvdwJ6P ckKkJocR45PGMuToJIZogKRw3hvg334xeY0U2CCvWlgX3YQY3j1Eeo7DNRg0pkjvYgdo bfbaZC/wIdb+Z4wsbmdDEM5ZCvBM6fuINA7ctfAfM+wx3EQ4SarpXcKW0FnsonqPalil 4LfHqeA5GZOVfhvoNOuiaXU9NElYhJH7NAQ4olMO0Xi+VYju8dyzrPBvyW8dWInR5N/z xblZvlfEpVnXNe3IIP0N6j6wKY4RyDj8CtrzTOEcffsOwNN4eNQNi//tTZZMf3BUsAoE xDQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765382178; x=1765986978; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+OGRmQE+ixhep3xbt9u4H6AZAUyykWLVpStmzWh+KI4=; b=fpOYyqgSxsHZS4RF6ErsHr+HuAAqAC7WjMZb80G8fR6Vj7CCh/nHY+bFFFMKeSl4W5 sbdfOel0OeWC1sWXESKARBPXGypS8myqYaBYQJ+SepKY4KyNXy+2GJSgly544uxMsORi EcuKOPxQxT+Q5DXeBWoZ+f9FTyjVVxOZYEDhWAGrukZsE62d5S2+N3CjrTRbcon5X1yZ e/V+Y2vjjSE8v4MvR+HSdN4l4e2Pl4uaCoFn42a8/lyA1nhxgwWJ5I3OjfW2RJaPlOZz ccXP6lkquVlriKbUAtPxK6FgroSQRrU5ANWPpXcxkGTlLjQ/R1mBp8IEQA6yyQx9nOgh Yz9A== X-Forwarded-Encrypted: i=1; AJvYcCUWwlLFWuTXmkWwkNkVrh8R+JQGyvC0/OrU/QhlfsYjSVdwxhMeWpXEPMdN3zjPiQfq6HMI7eNqElqQur8=@vger.kernel.org X-Gm-Message-State: AOJu0YyGUXsSnoz95RaHYF8YAywhLZjzB0gNdDLhe/Foxaqf/Df3NqMp NShID2XUJpsm7eh4o9k0Tdhe1A3lG2HCCvsu6gueApgkeZllVSAS6KqJTMGJ81g9bPCalwXqH0/ pHfBITLqE1YgOrLjkbHRxvy3kfRqo/sahpxsJckkXSgtJz+EINn2NBqdjK/FusWD6KNY= X-Gm-Gg: AY/fxX5kiBODG4C1NOu78rdOgLOcUfzwZNCIUvynB6xvlDk2WrmkfDcxb1TE4Ah3JaO zJU5Y30fGdERn3D5sJGkNRWn656H18Jsj5C20/T7tO/Fx6gPFt868tVBp1QpM7yjwAnI8fQ25ba 7OWy06TagPRQ0IeE8smx542fw5VspSDBVXw0FE22Mu/CeKDt2EzjVuc600UR80RNmt81YxAcK7T RoINKHzniYESM1LuLnMO4zkMpoTqmohj9Y8boVlfLWQXU3yRhkaEzB359dVMxaePEef607YYVPX sww6MCm+4EpuIHhPieeF/fGcBFRH8VBdp5RxMCOsaopGQKH/xUY2C2znqHV7Ic/GK2oitDx3b3+ YxhcyjVoA22dQrYWs++6HoUTPo5viv5iryOj2 X-Received: by 2002:a17:903:380b:b0:29e:940c:2cdf with SMTP id d9443c01a7336-29ec2d40b57mr28500675ad.36.1765382178561; Wed, 10 Dec 2025 07:56:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGA0XvA4RbT7trUTFcloLb7GnQpD6iy+sWQWnl98I717V8RldVFrLMOIKDNwIoWVdnQ1hizTQ== X-Received: by 2002:a17:903:380b:b0:29e:940c:2cdf with SMTP id d9443c01a7336-29ec2d40b57mr28500315ad.36.1765382178074; Wed, 10 Dec 2025 07:56:18 -0800 (PST) Received: from [10.218.4.141] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae4cf86esm186837595ad.23.2025.12.10.07.56.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 07:56:17 -0800 (PST) Message-ID: <23580203-3aa7-45af-872f-4bd86f39877b@oss.qualcomm.com> Date: Wed, 10 Dec 2025 21:26:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 2/3] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller To: Bjorn Andersson Cc: mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, James.Bottomley@hansenpartnership.com, martin.petersen@oracle.com, quic_ahari@quicinc.com, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251114145646.2291324-1-ram.dwivedi@oss.qualcomm.com> <20251114145646.2291324-3-ram.dwivedi@oss.qualcomm.com> Content-Language: en-US From: Ram Kumar Dwivedi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=cYjfb3DM c=1 sm=1 tr=0 ts=69399823 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gEfo2CItAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=I-uMcen_RorggYIV1ZkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=sptkURWiP4Gy88Gu7hUp:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: QB3sqGcFf0lLNPb64WgHQYx2QLoH7RS_ X-Proofpoint-GUID: QB3sqGcFf0lLNPb64WgHQYx2QLoH7RS_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDEyOSBTYWx0ZWRfX4eihwnyJ0I0L mvByuX2Bqdx2fnNvRfyudV2JZstbsKkRpExwG6/5TLmI7hZCTGfKxK1180JsyhJMA/dZ4YOLghX TBj19Z8tVP/03pTsdiQpenE+CaeBUUYgPNPX4/xhKOiuS0LNgljzRd7/bqrgNoDMK6jv/n74sPs JQE4hrRr3jX7RLuWrTye2nE8S8yvnUWiwmkalROhUxdrw0sUyUxPSEfDOIDua8sQ8Di95NqoC7l wyf8t5qSWtdHVYxEyDaOMkuSSZQa1RLvAag9HO6o10RcIsNv56a8FkHfkvKztCcRIjeyf8Zk6Qo X6e/YJchkseQyksVOvGbbt2UcF06kzAt5K3ocZQrK2uLQjlnIHyJwSHY42UH3xbkZ5vV/jsuHqm 27ztufTuIxdfJSdDnMJcz0A7iCpV3g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-10_01,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100129 On 15-Nov-25 1:02 AM, Bjorn Andersson wrote: > On Fri, Nov 14, 2025 at 08:26:45PM +0530, Ram Kumar Dwivedi wrote: >> From: Ram Kumar Dwivedi >> >> Document the device tree bindings for UFS host controller on >> Qualcomm SA8255P platform which integrates firmware-managed >> resources. >> >> The platform firmware implements the SCMI server and manages >> resources such as the PHY, clocks, regulators and resets via the >> SCMI power protocol. As a result, the OS-visible DT only describes >> the controller’s MMIO, interrupt, IOMMU and power-domain interfaces. >> >> The generic "qcom,ufshc" and "jedec,ufs-2.0" compatible strings are >> removed from the binding, since this firmware managed design won't >> be compatible with the drivers doing full resource management. >> >> Co-developed-by: Anjana Hari >> Signed-off-by: Anjana Hari >> Signed-off-by: Ram Kumar Dwivedi >> --- >> .../bindings/ufs/qcom,sa8255p-ufshc.yaml | 63 +++++++++++++++++++ >> 1 file changed, 63 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml >> new file mode 100644 >> index 000000000000..3b31f6282feb >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml >> @@ -0,0 +1,63 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/ufs/qcom,sa8255p-ufshc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm SA8255P UFS Host Controller >> + >> +maintainers: >> + - Ram Kumar Dwivedi >> + - Anjana Hari > > This should be @oss.qualcomm.com, or @qti.qualcomm.com, not > @quicinc.com. > >> + >> +properties: >> + compatible: >> + const: qcom,sa8255p-ufshc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + iommus: >> + maxItems: 1 >> + >> + dma-coherent: >> + type: boolean >> + >> + power-domains: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - power-domains >> + - iommus >> + - dma-coherent >> + >> +allOf: >> + - $ref: ufs-common.yaml >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + ufshc@1d84000 { >> + compatible = "qcom,sa8255p-ufshc"; >> + reg = <0x0 0x01d84000 0x0 0x3000>; > > Drop the two 0x0 and you don't need to change address/size-cells. Hi Bjorn, All current Qualcomm chipsets, including lemans, sm8550, sm8650,sm8750, use a 2-cell format (#address-cells = <2>; #size-cells = <2>;) at the SoC level, so I followed the same pattern here for consistency. We plan to use the same 2-cell format in the device tree for this chipset as well. Please let me know your opinion. Thanks, Ram. > > Regards, > Bjorn > >> + interrupts = ; >> + lanes-per-direction = <2>; >> + >> + iommus = <&apps_smmu 0x100 0x0>; >> + power-domains = <&scmi3_pd 0>; >> + dma-coherent; >> + }; >> + }; >> -- >> 2.34.1 >> >>