From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: Suman Ghosh <sumang@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>
Subject: Re: [PATCH net] octeontx2-pf: fix FLOW_DIS_IS_FRAGMENT implementation
Date: Fri, 12 Apr 2024 10:25:30 +0000 [thread overview]
Message-ID: <235918fc-9b9b-4efa-8258-69bd5c7d40d4@fiberby.net> (raw)
In-Reply-To: <27ac48c0-b19c-4104-8ec9-08232e3f42f6@fiberby.net>
Hi again,
On 4/12/24 9:01 AM, Asbjørn Sloth Tønnesen wrote:
> There are therefore 3 possible cases:
>
> - `tc flower ...` (no ip_flags frag or nofrag)
> (match.key->flags & FLOW_DIS_FIRST_FRAG) is false
> (match.mask->flags & FLOW_DIS_FIRST_FRAG) is false
>
> - `tc flower ... ip_flags nofrag`
> (match.key->flags & FLOW_DIS_FIRST_FRAG) is false
> (match.mask->flags & FLOW_DIS_FIRST_FRAG) is true
>
> - `tc flower ... ip_flags frag`
> (match.key->flags & FLOW_DIS_FIRST_FRAG) is true
> (match.mask->flags & FLOW_DIS_FIRST_FRAG) is true
I was a bit a hurry, to get the reply in before a meeting,
so: s/FLOW_DIS_FIRST_FRAG/FLOW_DIS_IS_FRAGMENT/g
There are therefore 3 possible cases:
- `tc flower ...` (no ip_flags frag or nofrag)
(match.key->flags & FLOW_DIS_IS_FRAGMENT) is false
(match.mask->flags & FLOW_DIS_IS_FRAGMENT) is false
- `tc flower ... ip_flags nofrag`
(match.key->flags & FLOW_DIS_IS_FRAGMENT) is false
(match.mask->flags & FLOW_DIS_IS_FRAGMENT) is true
- `tc flower ... ip_flags frag`
(match.key->flags & FLOW_DIS_IS_FRAGMENT) is true
(match.mask->flags & FLOW_DIS_IS_FRAGMENT) is true
--
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541
next prev parent reply other threads:[~2024-04-12 10:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 13:43 Asbjørn Sloth Tønnesen
2024-04-10 22:33 ` Jacob Keller
2024-04-12 2:59 ` Jakub Kicinski
2024-04-12 5:34 ` [EXTERNAL] " Suman Ghosh
2024-04-12 9:01 ` Asbjørn Sloth Tønnesen
2024-04-12 10:25 ` Asbjørn Sloth Tønnesen [this message]
2024-04-12 11:18 ` Asbjørn Sloth Tønnesen
2024-04-12 11:52 ` Sunil Kovvuri Goutham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=235918fc-9b9b-4efa-8258-69bd5c7d40d4@fiberby.net \
--to=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®