From: Shuah Khan <skhan@linuxfoundation.org>
To: Michael Ellerman <mpe@ellerman.id.au>, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
hannes@cmpxchg.org, nphamcs@gmail.com,
Shuah Khan <skhan@linuxfoundation.org>, shuah <shuah@kernel.org>
Subject: Re: [PATCH] selftests: cachestat: Fix build warnings on ppc64
Date: Wed, 29 May 2024 16:19:48 -0600 [thread overview]
Message-ID: <2359b378-d664-4d63-bd64-f539ec8607ac@linuxfoundation.org> (raw)
In-Reply-To: <20240521030111.56568-1-mpe@ellerman.id.au>
On 5/20/24 21:01, Michael Ellerman wrote:
> Fix warnings like:
> test_cachestat.c: In function ‘print_cachestat’:
> test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of
> type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka
> ‘long unsigned int’} [-Wformat=]
>
> By switching to unsigned long long for u64 for ppc64 builds.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> tools/testing/selftests/cachestat/test_cachestat.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c
> index b171fd53b004..632ab44737ec 100644
> --- a/tools/testing/selftests/cachestat/test_cachestat.c
> +++ b/tools/testing/selftests/cachestat/test_cachestat.c
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #define _GNU_SOURCE
> +#define __SANE_USERSPACE_TYPES__ // Use ll64
>
> #include <stdio.h>
> #include <stdbool.h>
Applied to linux-kselftest fixes for the next rc.
Michael, If you want to take this through, let me know, I can drop this.
thanks,
-- Shuah
prev parent reply other threads:[~2024-05-29 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 3:01 Michael Ellerman
2024-05-29 22:19 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2359b378-d664-4d63-bd64-f539ec8607ac@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nphamcs@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®