From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 770244F7CD0 for ; Wed, 30 Sep 2026 13:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790773413; cv=none; b=T0oESA4N+kYasCUBeucXGfRenhpbpkvG1N+n4oLsYfyAkLquNXEN9eIZ84i9aBmkTeGNNW4KGpkllobLjhWl48mZ4koGHE1ztGKUfHqqTpO4s9O4JWsslt3ZuJQvPbOEWuOIs9jLhzazxRiyOp9sV822M8D+AHGixCE/mRIthfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790773413; c=relaxed/simple; bh=H+DcAKtcxqYbxHPTih+Vv3PnTOLzwij99V2TWd7P1DE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eftqKW7EjEgamTNCiGgKIWifcgDixBFvC5Vb7zrAlCjnFXcjOosXqN0Lf3NxgY9qwQfZahbIU3lAHj80im1ixGrs8PJL+uw0Y+a4HLbteW4IlW85/oiGnHB2WhGEQX8p1eTGb/r+pW5/IvmACx9br0VaCM6Z1y5tk0MlqkmOOHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com; spf=pass smtp.mailfrom=6wind.com; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b=MNV4Xz6E; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=6wind.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b="MNV4Xz6E" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-4843178b1c8so568967f8f.0 for ; Wed, 30 Sep 2026 06:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1790773402; x=1791378202; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=babN9DRBy5azMYxvib8SKBkZUslU6O5ONocKKc4sKc0=; b=MNV4Xz6EaMuv65MQ7JfswBlkewKV/SH3bn7+57KAcGCM4b6ycvIVU3dQ/HbSYg0xeY svh1pB1BuZblJ5zblhb7YmW4MrZXqCQhnaoQb+Xr8Qhsb+dmD4lFFiL2szvYtDsFdfPr AsIEXGsvT/gRVMP+tVUCVepsk7//eQq253ZoGEUiY4AgUB0W7cHKr932Td+8JKm9fTAa 1Kgg4HxXiJX60ZLZ44b2/i14X4d6A8M7AUdJZcb1Xbhr+echJSg4HrU6ZCDJOEYKzZ1Z 9dEoJfC12dbGBEp/m+GJnEGh6o0vJm5uIkp64KH4+pEC94moRP6ttlfwX0Bqv/P7LTYe VQWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790773402; x=1791378202; h=content-transfer-encoding:content-type:in-reply-to:organization :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=babN9DRBy5azMYxvib8SKBkZUslU6O5ONocKKc4sKc0=; b=OcEmJ5S5r+56XR2cwZVM0LGUgFPXZNM0DQDw9Lbv34JQ5tZ3ZaQXdWCiM6VjSmSm5W U9yxDG0H9ueXVBlufWbfY7sPIO4dAY5Y73ES5/wY3AY7R6orn4k91cb1jL5iJUmZOTIW 3o4nm1Cd0RoPsEVE+EGoAu1JPUzpEo0d+oBdhNd06pCROZcNLMAut4wD6anZIZuTZwPE PIOO8LjWWKDlroTtAhuAAim3HMiFZshpcXnJotM88beQgY9c+DnLRVlG8hjPbtnqm44S l1hJyLc8GYc3lW/raviCs4+hu4V2KesB98d2Nax66GXDfOTOXS53G2lKtWdZOMxDHcyi tEAw== X-Forwarded-Encrypted: i=1; AKwUvBzwQUmkbboB7pd9FFBY4zkYowMJ40ucYeJX0R6483Y2TmtZ7D6Yx4EGYfN+2atHxIDhJTu/77jZLmUA0YA=@vger.kernel.org X-Gm-Message-State: AFq9FYL+EHu4+JYrem4Lp5Yp70IyrnA4xadCM0Z3l9Sp2seM1K0QB0d6 QZYEgrYHIpzDRC8jA/+Vvs3OS/qYyiCdnIS0TQV/0vmEEO13Ms/QRKxlPwc1+m5peLg= X-Gm-Gg: AYBFou2uSdHYocoeLMR/810I4WG5ZoUF2FKaGv2psUBiLC/+0mb7L6fEJtSD4obdBMl Ejcv+Hp44HssWFuhUyxaiU3/rYDefarXTiuJWmfRthAI5Jh7f+COy9wVQqDRDjIGYMhFf/LIcJ9 Xdsn0VA2r4vmXFun7x/CGkktPFr20gWbiSHAuXkxfo+VH1ZQASIniSjvVGHqCMOGIK/BHyAEwk2 X9clcX2S1yxSEMnpNL4j2XZUKgum+GiwQw+E4imYhmMqyaxmjbwbqoPNO3w7nJZDnGzTQMMF0RM l7SGApGEvzlqYurwXewGN3WKuVUiHqFf24MMSFsevO3dDcwWrf0rMtXLlf8qzdjl7LTbyWEBJrX T48I+YLmgvVR1856paJUjQ0GwYg1+CRvsaCJlfTVrIGRdYT9nQ2cRLZOD05DqeqpxcHsQ49LoXx KVf5P2DH+FhxPTWdOoGZHkYNP8hYvOxmYuFUmodfGNJyMHshw8F2cqh6k/l/MtQhU6R8rcupwFP wHtXrlVpXh+KJGZlLUzSeOOsrr233sEG4q8eGFf2E+24DkClt4= X-Received: by 2002:a05:6000:18a8:b0:487:342:d145 with SMTP id ffacd0b85a97d-48b0245d2ebmr2617321f8f.2.1790773402155; Wed, 30 Sep 2026 06:03:22 -0700 (PDT) Received: from ?IPV6:2a01:e0a:ab7:2110:6a1d:efff:fe52:1959? ([2a01:e0a:ab7:2110:6a1d:efff:fe52:1959]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b02a0185asm3461189f8f.32.2026.09.30.06.03.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Sep 2026 06:03:21 -0700 (PDT) Message-ID: <235a33c2-7138-4815-820d-793568757d95@6wind.com> Date: Wed, 30 Sep 2026 15:03:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next v9 2/6] net: change netdev_hw_addr_list count through helpers To: Yuyang Huang Cc: Ajay Singh , Aleksandr Loktionov , Andrew Lunn , Claudiu Beznea , "David S. Miller" , David Ahern , Donald Hunter , Eric Dumazet , Ido Schimmel , Jacob Keller , Jakub Kicinski , Johannes Berg , Kees Cook , Kory Maincent , Kuniyuki Iwashima , Nikolaos Gkarlis , Paolo Abeni , Sabrina Dubroca , Shuah Khan , Simon Horman , Stanislav Fomichev , Vadim Fedorenko , Willem de Bruijn , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org References: <20260930112842.21323-1-sigefriedhyy@gmail.com> <20260930112842.21323-3-sigefriedhyy@gmail.com> From: Nicolas Dichtel Content-Language: en-US Organization: 6WIND In-Reply-To: <20260930112842.21323-3-sigefriedhyy@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Le 30/09/2026 à 13:28, Yuyang Huang a écrit : > The count of a netdev_hw_addr_list is changed in several places of > dev_addr_lists.c and a few drivers read it directly. The next patch > needs to account every change of the count of dev->mc. > > Add __hw_addr_count_add(), __hw_addr_count_inc(), __hw_addr_count_dec() > and __hw_addr_count_reset(), use them for every change of the count > and rename the field to _count so that a direct write stands out. > Readers keep using netdev_hw_addr_list_count() and the netdev_uc_count() > and netdev_mc_count() helpers, the few that read the field directly > are converted. No functional change. > > Signed-off-by: Yuyang Huang Reviewed-by: Nicolas Dichtel If you respin a version, you can use netdev_hw_addr_list_count() in __hw_addr_list_snapshot() also. Thanks, Nicolas