From: Rudy Matela <rudy.matela@gmail.com>
To: wharms@bfs.de
Cc: Jan Yenya Kasprzak <kas@fi.muni.cz>,
Krzysztof Halasa <khc@pm.waw.pl>,
trivial@kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Coding style correction on some drivers that use Generic HDLC
Date: Wed, 9 Dec 2009 18:09:54 -0300 [thread overview]
Message-ID: <235c15c10912091309q6c20b417y3f80dbac0be2a073@mail.gmail.com> (raw)
In-Reply-To: <4B1FC5A4.9030300@bfs.de>
On Wed, Dec 9, 2009 at 12:43, walter harms <wharms@bfs.de> wrote:
>
>
> Jan Yenya Kasprzak schrieb:
>> Rudy Matela wrote:
>> : Added a space separating some if/switch/while keywords from the following
>> : parenthesis to conform to the CodingStyle.
>>
>> Hello,
>>
>> I am not sure whether it is necessary to fix formating mistakes in
>> a driver which is in deep freeze and the hardware is not produced anymore,
>> but whatever.
>>
>
> It is ok until the driver is removed, if this "issue" is not fixed it will
> trigger any check-coding-style and generate new patches. Since it involves
> no code changes it is harmless.
>
> re,
> wh
>
>
Hello to all,
Sould I keep sending coding style corrections to the Linux Kernel?
I'm trying to help, but if i'm just being annoying, please tell me and
I can try to contribute in a better way. :-)
Regards,
Rudy
next prev parent reply other threads:[~2009-12-09 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 14:35 Rudy Matela
2009-12-09 14:55 ` Jan Yenya Kasprzak
2009-12-09 15:43 ` walter harms
2009-12-09 21:09 ` Rudy Matela [this message]
2009-12-09 23:26 ` Jiri Kosina
2009-12-10 0:40 ` David Miller
2009-12-09 16:41 ` Krzysztof Halasa
2009-12-09 23:24 ` Jiri Kosina
2009-12-10 17:41 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=235c15c10912091309q6c20b417y3f80dbac0be2a073@mail.gmail.com \
--to=rudy.matela@gmail.com \
--cc=kas@fi.muni.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®