From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932766AbdJQW4Z convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 18:56:25 -0400 Received: from mga03.intel.com ([134.134.136.65]:16231 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932580AbdJQW4X (ORCPT ); Tue, 17 Oct 2017 18:56:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,392,1503385200"; d="scan'208";a="1231941721" From: "Dilger, Andreas" To: "Gustavo A. R. Silva" CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 02/20] staging: lustre: lnet: socklnd: mark expected switch fall-through Thread-Topic: [PATCH 02/20] staging: lustre: lnet: socklnd: mark expected switch fall-through Thread-Index: AQHTQ3V7B4IPqmqa2kaqfMOymGl896LpJLgA Date: Tue, 17 Oct 2017 22:56:21 +0000 Message-ID: <236BFBC5-3722-413F-A8F9-1273E2221A24@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.142.85] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 12, 2017, at 10:16, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva This isn't strictly necessary, since LASSERT() never returns, but not harmful either. Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c > index d0ee58d..7b014ca 100644 > --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c > +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c > @@ -2308,7 +2308,7 @@ ksocknal_base_shutdown(void) > switch (ksocknal_data.ksnd_init) { > default: > LASSERT(0); > - > + /* fall through */ > case SOCKNAL_INIT_ALL: > case SOCKNAL_INIT_DATA: > LASSERT(ksocknal_data.ksnd_peers); > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation