From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2187343884 for ; Thu, 23 Jul 2026 03:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784775911; cv=none; b=pEhdQuNpFsLDG1A51UV2jvFrd9ERCSCgVpPWSMZXGn8CaA+yPZ+HYZpgGdTSRt/ejl1LcWBkyJl4X9kx95+LditwPcX0OF+xeSI5RLth9tqwkfWhymiqUBVYuo0r0IjiCEZLpNg6xEfVhgKIFyWMT/4aLmE6WpLwsXO8DuxKyD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784775911; c=relaxed/simple; bh=Ox96qHvn47+bpDeRKjnqV2scGXDoWxEm9KijiBs3wr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nPs1k8ciFCb7rlmGQ1TgfODSAsetDX8pMAaIwAO3RtUUuEk02h+v7SUwI/sXa76gltlpqtpowf4s8SiCLKzxq3gII1O+U7CloEQsM2H3MLA7jGyt9CknJwbHn90uz84Aeg5Mi0llQaWCFXq0tdio0EkQKKiyUHiNekzBzdamnTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C5N2xAIw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=azWgu7sO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C5N2xAIw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="azWgu7sO" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N2lL3g2435001 for ; Thu, 23 Jul 2026 03:05:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5HM0b+gY2t3sPr+G6m2re9kStqVxWC/05ySGuYZwjEs=; b=C5N2xAIwB68UaBld waSrddvYUXuTcmZIg6G7VczquzU4Soi4EQD6/pN7CJsfyWDek85js1qRPwQYMrvK Z7RKm6ASRxoSRfuaHWLsF7wP2LVAwQhVDdCAzb+IcbhyInV2KwJeF7C7/3LLbeDB 52W3w4WbvkuLuYVE/YhzpxMR4wr/qLJtGaOMz/OX1d2qM83VsgknvXLMTK4jDWg1 21DJ8ZeTMYJaDylLNblMMxuvw8DhK6xCDaJRkWxty66qh+1z8VSE0NaZ7/pBWxwI AZ6wRu1rhqaoaimjNH+oMsuKZDfVr7UF0O43heotVadd60hHO0OZIh01k6uzeBqx fkwnfA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fkafw02d6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 03:05:08 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c0408254aso3435081cf.0 for ; Wed, 22 Jul 2026 20:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784775907; x=1785380707; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=5HM0b+gY2t3sPr+G6m2re9kStqVxWC/05ySGuYZwjEs=; b=azWgu7sOqKrhY7pC+ag5xZYLvuzsi/zaROCzzZRV61pWs5Nn48q9BwiOdRrHb/NZu1 8vfcNZTjSezYzxup/6iJd8su6Go6efJ/VBqYlgfOV/4OpDvMqa86/D+BFRQ1gV/0sIjb f3Z0lt6di2iMnNRUa0Q9SuPx3tlTOJ6pWV+/zL7L7DacmyUHaCHwuYlH9T5cNtIBF8do zGrnykGHvUtv1NQ2xRBBE8ZtnixztvLtWOs2BY9+FgkVn2gIOeEhHz1GPNDkhe4JNINq shA1izurWqxNBUfrAE1tNGzisv5C1cKZtmQTGMqYNo7Bks/VYFPq+zTk4sUcGFn5NVz+ zOoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784775907; x=1785380707; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5HM0b+gY2t3sPr+G6m2re9kStqVxWC/05ySGuYZwjEs=; b=YsM8Rw6YoW74pQld0O01qC0xQk2f+9AvXwrtWCg0aaKZjH2z9F0ibS6pJ2LFj42giC Vy2Q76yXXUV21Bdagm0k92Midv2U5e9aV2pcrPrT/AaHmafu/3MpxCvUca717CvivrTS 2aWQ3hNvCoHlcYC3imaNGCOEGv+sieiVprnKx7gMvAa0m0ynFBV407ILQQETD5BTPJ4p fVZCKtVGvV7iIH7ws1k+PT2iUkkEsqtzL8idwL4dTwObf5DCwKgXGg+Jj7pZQmhjcar+ m3YHTnxtoqla6ICoFWkGeIgSLneOj3t8NkHswh0V30Jd6mfkwD3KXgsQ/DmbZrO8uI5E 7BiQ== X-Forwarded-Encrypted: i=1; AHgh+RqK5Lm3MayOlO1KB+3Jp0RWOaqGPrZoUw7Cp5wUkRltur28gYkRz7k7jMxFZlxAXW+inKam/+PA9DSDaXw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl+l537vIzjrpu8XhmfH7B6IBGGdF/1ryuqtLGQc7l3SGZOCKN bKASww7B6IEBhigf1QwgFTpTOikPnF5B4yhSwQ1hA3EexPmM+QrLZH0GZNwyjCPMvpWAey3tZ0i rI9lReCwY9IfWWx56bgbda2ASSTqWADQ360VLpDBi3axNgJmf7zDdpCf+GBE5aIvhJ5W8TezDd7 IO7/Ay X-Gm-Gg: AR+sD1387/rrOcckY+8RuTxtarVKSFXiuoX/1VScwSLfS03BsKMquOFcFj2Wo9iCDmF 1jg0V7MyB/obUmpVanI7v3T5N8ALnFIOaiT737HSH9A8GUHdnnbWQfG7UmvMfSkYqZYKfV/1CYX 6EQcvMiQYlO9xwFy1wEjNeOljEZYjFDkMTTRWBpIJ81Uc9QJ0qQCE5nuhI8YPX9vTBo76txPya3 SD3nBjxLQ1rDgbKmmTkmk8u/t8HG0AoKu1EfT7o36G/fQkZvFN2G6Lj63vQ/o831+UoLH/MO4Oc DRAFxBjaK/MlrGAg6bnhwv6akt1Xjh5tur2iPe19mz6FpbUqgA1XKIxuYWsWd9vOtSDJHnZOyQv Ow8eofGnngJcuhJd0HBaadqeF9lonBfpwCHANHu0Pt/Ys92GUOc7lJ9ABd6A5xtkl X-Received: by 2002:a05:622a:1dce:b0:527:69ad:fceb with SMTP id d75a77b69052e-5283eaca354mr5740901cf.0.1784775907092; Wed, 22 Jul 2026 20:05:07 -0700 (PDT) X-Received: by 2002:a05:622a:1dce:b0:527:69ad:fceb with SMTP id d75a77b69052e-5283eaca354mr5740751cf.0.1784775906595; Wed, 22 Jul 2026 20:05:06 -0700 (PDT) Received: from [10.111.167.143] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-527d066e84fsm27005551cf.3.2026.07.22.20.05.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 20:05:05 -0700 (PDT) Message-ID: <236c2b1d-7118-4ed2-80c5-a5dd78b2834d@oss.qualcomm.com> Date: Thu, 23 Jul 2026 11:04:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] i2c: qcom-cci: Fix CCI clock rate enforcement To: Loic Poulain , Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> From: Wenmeng Liu In-Reply-To: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XNkAjwhE c=1 sm=1 tr=0 ts=6a6184e4 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=oA7RtkSea3Gl-iE8cOoA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: z6IdqOPaiNw6bUJd8WmmWo5SSqgeh-uo X-Proofpoint-GUID: z6IdqOPaiNw6bUJd8WmmWo5SSqgeh-uo X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDAyOCBTYWx0ZWRfX116EUcvGn3t9 nTJPe2vsEH2w3+uUjf8N5fIHN6iKcexdsedShIw7apz/RQV21k5lSIGqFySQdXcDKeR7+lyp4uc XCRcjZayo1qmbNXb+omEEcG9s0ET8Zw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDAyOCBTYWx0ZWRfX25Uq1MkWPoKa 460KwtCChAGAr3Z7ZJOh1P5EH6gumnqsHFULIZWsgzR0FGjD0pNfZHavBZ6CQ3KOk0YQnFAHEo+ MFOo1jTqH9CUMPq17xzoU/e34Sn9sw0OuHexp8KaIvXDjRIMsgIQyr4GPKA5390xGzLhYmbKzxf njoMJa31KG0xvxFaWL6lJrm7Ul7p8rdmcdMK+nbxEjeQngg/LLPCplM/efgjBGMOxNZ9KFn6oHZ 1mSx00uRCSRs/QjtnmwcTX5OTBhM/B/9qYAadbC9TUeGqcImxriwvGUYcsk0Sk6YIJc1pV6wo76 BjHAWziy0Lor//w9Ujh4tkRJkoqwt/BuFRDdPcfeaua4uU9OPcg5iiqSmc8NqL22I3vrhIett8w ZvsZBpUK8o6utfO+D3e24ngmLdtLZSpvfQjUN+IBl5q+itfQ3aDANbM6pFLCWHAAyVt88Wqbz6F S1aujzQp2k1jyMYLR7g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 suspectscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230028 On 7/21/2026 10:58 PM, Loic Poulain wrote: > The CCI hw_params timing values (thigh, tlow, etc.) are expressed in > clock ticks and were calibrated for a specific CCI clock frequency per > hardware variant (19.2 MHz for v1/v1.5/msm8953, 37.5 MHz for v2). > Running at the wrong frequency causes incorrect I2C timings that may > violate the I2C specification. > > A previous series removed the cci_clk_rate field and the associated > warning from the driver on the grounds that the warning was noisy and > the rate was already set via assigned-clock-rates in the DT. However, > enforcing a clock frequency configuration through DT is fragile and not > the right approach, the driver owns the hw_params and should own the > clock rate too. > > This series reverts the removal of cci_clk_rate, fixes the missing rate > for the msm8953 variant (added after the field was removed), and > replaces the passive warn-only approach with an active clk_set_rate() > at probe time, retaining the warning for cases where the rate cannot be > applied. > > Signed-off-by: Loic Poulain > --- > Loic Poulain (3): > Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate" > i2c: qcom-cci: Add missing cci_clk_rate for msm8953 > i2c: qcom-cci: Fix CCI clock rate enforcement > > drivers/i2c/busses/i2c-qcom-cci.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > --- > base-commit: fce2dfa773ced15f27dd27cd0b482a7473cdcf2a > change-id: 20260721-cci-clk-fix-fe145b2acfa7 > > Best regards, For this patch series: Tested-by: Wenmeng Liu