From: Jijie Shao <shaojijie@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>, <netdev-bot+sinfo@kernel.org>
Cc: <shaojijie@huawei.com>, <davem@davemloft.net>,
<edumazet@kernel.org>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <shenjian15@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<yangshuaisong@h-partners.com>, <ningwei15@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 net 0/4] net: hns3: fix multiple bugs in reset/error paths
Date: Fri, 13 Nov 2026 11:11:47 +0800 [thread overview]
Message-ID: <23712c53-4b0e-47b7-b080-a8b5e5584a1d@huawei.com> (raw)
In-Reply-To: <20261112110631.2ec2d378@kernel.org>
on 2026/11/13 3:06, Jakub Kicinski wrote:
> On Wed, 11 Nov 2026 13:01:03 +0000 netdev-bot+sinfo@kernel.org wrote:
>> Please do not repost the series just to address the above. Instead,
>> reply to this email with the missing information, so that reviewers
>> can take it into account. If the series needs another revision for
>> other reasons, please include the information in the commit messages
>> then.
> Please make sure you include the answers to these questions in the
> cover letter if you repost
ok,
Patch 1: found in internal code review. Not hit at runtime - it needs
devm_kcalloc() to fail after get_vector() has succeeded.
Patch 2: found by Sashiko on v2. Error path only, not hit at runtime.
Patch 3: real customer issue. Under memory pressure the RX ring filled
up, no more RX interrupts came in and the interface went dead. No stack
trace, the interface going dead was the only symptom. Reproduced and
fixed on EVB.
Patch 4: hit on a lab EVB while reading the debugfs queue files during
reset/unload. NULL pointer dereference, machine hung.
All four were built and tested on a Huawei Kunpeng evaluation board (EVB)
with the on-board hns3 NIC. Patch 1 and 2 were not exercised on the
failure path.
Thanks,
Jijie Shao
prev parent reply other threads:[~2026-11-13 3:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 12:58 Jijie Shao
2026-11-11 12:58 ` [PATCH v4 net 1/4] net: hns3: fix vector resource leak in hns3_nic_alloc_vector_data Jijie Shao
2026-11-11 12:58 ` [PATCH v4 net 2/4] net: hns3: fix page_pool leak in hns3_alloc_ring_memory error path Jijie Shao
2026-11-11 12:58 ` [PATCH v4 net 3/4] net: hns3: fix interface stuck after OOM with full hardware rx queue Jijie Shao
2026-11-11 12:58 ` [PATCH v4 net 4/4] net: hns3: fix use-after-free in debugfs read during reset/unload Jijie Shao
2026-11-11 13:01 ` [PATCH v4 net 0/4] net: hns3: fix multiple bugs in reset/error paths netdev-bot+sinfo
2026-11-12 19:06 ` Jakub Kicinski
2026-11-13 3:11 ` Jijie Shao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23712c53-4b0e-47b7-b080-a8b5e5584a1d@huawei.com \
--to=shaojijie@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ningwei15@huawei.com \
--cc=pabeni@redhat.com \
--cc=shenjian15@huawei.com \
--cc=yangshuaisong@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®