From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCFC131353C for ; Tue, 23 Dec 2025 09:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766483602; cv=none; b=EjmUrwPkymyjMiV2OOE0gYUGKvwU8Flos+TjN7xUXG6gLsWsl1rVAB0vnmXyt1Bn0VmnkG+lSLG8xfnhdbTMwo1gIqCw2M2KtruuNZZtue/WNM9NiDHMYrjw/Rn+h+k7JL8+Mz0eVaHQBHyAobp88T1rL4RvS96itTcSfhI+ds8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766483602; c=relaxed/simple; bh=nN5iKsjCNbTu18h5SD9L9HSxTjXfav/iLdgp9LKyEsA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OVF1s2Fmr9GoNEIg64g6rkzXkuniFVBy6a8GIdJIWshUBuIOLMf/pRsktcmoWc4RslK+9/yo0MkCVhPvhubUHcBNFC6nhA5TuCXgbHGck8uhRenVQPryqNz3Djxynamo4McO23A0gGSdYtgRltjadu1qv+QRBXNJmR+8XO4miy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W3BZKMDg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TKfN7Lub; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W3BZKMDg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TKfN7Lub" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BN2tDmZ1529451 for ; Tue, 23 Dec 2025 09:53:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rueDqM5R/QJzu4XQ07WkZ5PUKgVruLuJrOOv/52SRXE=; b=W3BZKMDgz6qDfs2A ImINVOVBVssM9H+CCD5ziScGxEHvzMA6/DmfqZB+U+ue1XX2oABCLq5gfdmZVUfS ggwGRZ9xJrTkLdGVfqf+mxBQCt5jW8i3WFpnO3mGkbGQJx+9iaIrOi9fmtTD4+a4 XBSt6jzAwBEpsw8WzSMEjg1hNJKnzIxp68VJX+LE9Z8ZVa1AGjXdYqeucVYfMpDH ASM5UCALH3g6ssmmYtPhWFxnh6klSgtk37hpBynMDyz6XEPoYgeUHKan2R0dtFZJ oGk0JDdkH89iCfQbq7Hl3czpGcgQi1BJHMTlQW3wPndvdgZcwx5Ai/BMUABw5+75 5Z/GDQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b758y3f4k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Dec 2025 09:53:19 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0dabc192eso107910245ad.0 for ; Tue, 23 Dec 2025 01:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766483599; x=1767088399; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rueDqM5R/QJzu4XQ07WkZ5PUKgVruLuJrOOv/52SRXE=; b=TKfN7LubHukAdU/EdRlXwucsCzDO5voX0i0SOdDb6MeoWRX5KemUnO2MVJAYQn9Y69 PWf2baCi8jQfwDRmwf2f1x8Vn39+81GMiPUrPJdehbI53A1w42HrEspWi+x2ZP5XQBon pUTzIZYrIkXCY2qWKpuOZk6sdi40fNG2aHakm64HfFjkvAh8fGO15lYH2aIytf6JvDWk soS0M0l66whJi9832mQ6INFG8RRhpTjJKZvXnod58okC0ZQtE/4KtqAMFKGw4OF4LCmf cuz9YFmf1lJUdvUXJIAU3Vp6i5kJOBekhaTpHtfgSSF1XXvi6KeO5JP+v/ko2O+nj1eg KHIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766483599; x=1767088399; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rueDqM5R/QJzu4XQ07WkZ5PUKgVruLuJrOOv/52SRXE=; b=MJH4X7wPLphOQS2sPi8C4R1H307UJqx7WzCbER0QexjQD0jHwVBrNToZjJo7muNyZN lPwN1AdbwE8jkY4Sa+DR3+X47BKCLBBd8cIqwaPi70XlfAaXFnXh06VvZpFOPfvylxW6 jB7Ni14p3fni+J37h2YReof7gsVGoQIhY+ubr2CT6A/H9szgT3rgVJDrDWyk12rEfkVe x5MYHzDusFhIzZW1bq+EOaMxEuYnaG4nX2lXHS/qAQjqEpCwimvPdSj4zq/cI8/eidUe dzAtfjQ1LhbcfLRRFhWAU9RurR9+xbp8FxwBMmfzi/+bxApPlfLM1QChBIcEQJNyFm1X wiYA== X-Forwarded-Encrypted: i=1; AJvYcCU7zvAR1LGOAyqzgUi0kf7ZJwjzokCpgaa42KQxL5a0nM4PYKPF1jPYIINxzauDlKGZdhSeEJq1+mEdD+A=@vger.kernel.org X-Gm-Message-State: AOJu0YwRAbdwQBuMyxomKOpCOhsrqZXAFR0wFBxT0HicAgrLMiClouoI gzIUYFXAz7nYtf/aEnuwotokmx1xbCpw5tfxXqw2KEqzv2iSZcmVp3tpfC1SrGKajV2Ds9sCkP5 wOWJOWAHpCW77+Qf7rXzOMgnOFK5dHh4OFIt4dzFwJqLHncgTJUwIcNKIpe3sCeKVfZuLq8/dtm MFVw== X-Gm-Gg: AY/fxX4ZBjxwL0ylKgbHwg2qR/VBLjjiG+Y/UvNBIGCsN3NV2G4WHiWYlZH/H9HUq1r uuxPOY72xXHTbOVOPxgowIwBLtfZi+fZsP885f+I8BjWqkC0aG70rZ3y/laLXeg88BYQTcRLdc1 PHBMmhW+zrMrwdDanVyNi9uTfFapNI2pkHk4gTmeArS64oF4GHuA9HyC51GIqSxSACXBPRSABvd 9yz5jD/4CYEL4lQlr1HqLzEXvX97PIU86RGMVEgnSwNXTc5BiYlrQbovBfsqlgT+HGgIRhSCeZ8 3RQgp6iD8a48CVOJA9AdYS65n83wPIcFqMvYlEsFr3kcuApwNYx+NcnRm77hKql+zE0f7+YJcAZ CAYSDACNjAhBjDRKWiL7sOy5zRP44f5MHn5HoUI4MwoYB4oLK1BU6FkY8yM7YecMT5CTwW3nOpp A= X-Received: by 2002:a17:902:e803:b0:2a0:d5b0:dd82 with SMTP id d9443c01a7336-2a2f2a420e1mr140856975ad.61.1766483598978; Tue, 23 Dec 2025 01:53:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNt7A8ugJxNnv6i4qUo7cz7Q5h/AKiyqpJFPuFCzO3I1pykcdS9W5estsBjuHvSKmn24d4mg== X-Received: by 2002:a17:902:e803:b0:2a0:d5b0:dd82 with SMTP id d9443c01a7336-2a2f2a420e1mr140856825ad.61.1766483598453; Tue, 23 Dec 2025 01:53:18 -0800 (PST) Received: from [10.133.33.169] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e9223aab0sm12603184a91.13.2025.12.23.01.53.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Dec 2025 01:53:18 -0800 (PST) Message-ID: <23737351-e254-4b2c-a3e3-bc7eebb1c025@oss.qualcomm.com> Date: Tue, 23 Dec 2025 17:53:12 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/4] coresight: tpda: add logic to configure TPDA_SYNCR register To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tao Zhang References: <20251223-add_sysfs_nodes_to_configure_tpda-v7-0-db4e6810047c@oss.qualcomm.com> <20251223-add_sysfs_nodes_to_configure_tpda-v7-3-db4e6810047c@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=TOdIilla c=1 sm=1 tr=0 ts=694a668f cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=ftp70H-Omfm4tq10K7kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: xDtm7W9ox_pYLF02dAFJPn4at9rdk0-i X-Proofpoint-GUID: xDtm7W9ox_pYLF02dAFJPn4at9rdk0-i X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIzMDA3OCBTYWx0ZWRfX64KC86KtXgsZ mLRTNn6CWBDgDnpnpI6C9jGVc90+mwCeha/KQLbI+bkWNJnmej8YDucyBSXM6/vC/cPBEjqPSIv ZbMWZFqBavvX8UKygPbuEqZMpGaZX3N+yg+tZAHaEx4bb9nV5TGAyfVXPuFIn+Cw1sybJo5eFax V8kHLSWtvXchVR83KAUEs9Qxt+jIFfyN+etljHsDDz81U05ong0oCUDgGfk6MGsunC8E5KwCSrN gAY5BjkRxcKkJTel7BpuE4vSkNtdgUUNgTwHKQILbdzuxU7A7HnhjsSxUUrREJLFSbrYkluA0xa uGJq7BaWWZagDAlCpxbhBx3uLbBHoBQoJM1W8TxDYArvJznup8wDQ7zjGz325Ce8nQh/co7m0nF 8esiXvdHzI67M832ywQQhRnQdbPLAlNfuFHvedhiCm6hJT/A2hXQK1bfWVkO4Yr2C4cJPcbhAWF 3mLsjhEyNVi4aifTacQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-23_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 impostorscore=0 bulkscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512230078 On 12/23/2025 5:49 PM, Suzuki K Poulose wrote: > On 23/12/2025 08:41, Jie Gan wrote: >> From: Tao Zhang >> >> The TPDA_SYNC counter tracks the number of bytes transferred from the >> aggregator. When this count reaches the value programmed in the >> TPDA_SYNCR register, an ASYNC request is triggered, allowing userspace >> tools to accurately parse each valid packet. >> >> Signed-off-by: Tao Zhang >> Reviewed-by: James Clark >> Co-developed-by: Jie Gan >> Signed-off-by: Jie Gan >> --- >>   .../ABI/testing/sysfs-bus-coresight-devices-tpda   | 18 +++++ >>   drivers/hwtracing/coresight/coresight-tpda.c       | 90 ++++++++++++ >> ++++++++++ >>   drivers/hwtracing/coresight/coresight-tpda.h       | 10 +++ >>   3 files changed, 118 insertions(+) >> >> diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices- >> tpda b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda >> index c8bc7b19ab25..c989eea1ef59 100644 >> --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda >> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpda >> @@ -41,3 +41,21 @@ Contact:    Jinlong Mao >> , Tao Zhang >   Description: >>           (RW) Set global (all ports) flush request bit. The bit >> remains set until a >>           global flush request sequence completes. >> + >> +What:        /sys/bus/coresight/devices//syncr_mode >> +Date:        December 2025 >> +KernelVersion:    6.19 >> +Contact:    Jinlong Mao , Tao Zhang >> , Jie Gan >> +Description: >> +        (RW) Set mode the of the syncr counter. >> +        mode 0 - COUNT[11:0] value represents the approximate number >> of bytes moved between two ASYNC packet requests >> +        mode 1 - the bits COUNT[11:7] are used as a power of 2. for >> example, we could insert an async packet every 8K >> +                 data by writing a value 13 to the COUNT[11:7] field. >> + >> +What:        /sys/bus/coresight/devices//syncr_count >> +Date:        December 2025 >> +KernelVersion:    6.19 >> +Contact:    Jinlong Mao , Tao Zhang >> , Jie Gan >> +Description: >> +        (RW) Set value the of the syncr counter. >> +        Range: 0-4095 >> diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/ >> hwtracing/coresight/coresight-tpda.c >> index d24a9098f1b1..8283e16ec400 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpda.c >> +++ b/drivers/hwtracing/coresight/coresight-tpda.c >> @@ -163,6 +163,20 @@ static void tpda_enable_pre_port(struct >> tpda_drvdata *drvdata) >>        */ >>       if (drvdata->trig_flag_ts) >>           writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); >> + >> +    /* Initialize with a value of 0 */ >> +    val = 0; >> +    if (drvdata->syncr_mode) >> +        val |= TPDA_SYNCR_MODE_CTRL_MASK; >> + >> +    if (drvdata->syncr_count > 0 && >> +        drvdata->syncr_count < TPDA_SYNCR_COUNT_MASK) >> +        val |= drvdata->syncr_count; >> +    else >> +        /* Program the count to its MAX value by default */ >> +        val |= TPDA_SYNCR_COUNT_MASK; >> + >> +    writel_relaxed(val, drvdata->base + TPDA_SYNCR); >>   } >>   static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) >> @@ -385,8 +399,84 @@ static ssize_t global_flush_req_store(struct >> device *dev, >>   } >>   static DEVICE_ATTR_RW(global_flush_req); >> +static ssize_t syncr_mode_show(struct device *dev, >> +                   struct device_attribute *attr, >> +                   char *buf) >> +{ >> +    struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> +    unsigned long val, syncr_val; >> + >> +    if (!drvdata->csdev->refcnt) >> +        return -EINVAL; >> + >> +    guard(spinlock)(&drvdata->spinlock); >> +    syncr_val = readl_relaxed(drvdata->base + TPDA_SYNCR); >> +    val = FIELD_GET(TPDA_SYNCR_MODE_CTRL_MASK, syncr_val); >> + >> +    return sysfs_emit(buf, "%lu\n", val); >> +} >> + >> +static ssize_t syncr_mode_store(struct device *dev, >> +                struct device_attribute *attr, >> +                const char *buf, >> +                size_t size) >> +{ >> +    struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> +    unsigned long val; >> + >> +    if (kstrtoul(buf, 0, &val)) >> +        return -EINVAL; >> + >> +    guard(spinlock)(&drvdata->spinlock); >> +    /* set the mode when first enabling the device */ >> +    drvdata->syncr_mode = !!val; >> + >> +    return size; >> +} >> +static DEVICE_ATTR_RW(syncr_mode); >> + >> +static ssize_t syncr_count_show(struct device *dev, >> +                struct device_attribute *attr, >> +                char *buf) >> +{ >> +    struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> +    unsigned long val; >> + >> +    if (!drvdata->csdev->refcnt) >> +        return -EINVAL; >> + >> +    guard(spinlock)(&drvdata->spinlock); >> +    val = readl_relaxed(drvdata->base + TPDA_SYNCR); >> +    val &= TPDA_SYNCR_COUNT_MASK; >> + >> +    return sysfs_emit(buf, "%lu\n", val); >> +} >> + >> +static ssize_t syncr_count_store(struct device *dev, >> +                 struct device_attribute *attr, >> +                 const char *buf, >> +                 size_t size) >> +{ >> +    struct tpda_drvdata *drvdata = dev_get_drvdata(dev->parent); >> +    unsigned long val; >> + >> +    if (kstrtoul(buf, 0, &val)) >> +        return -EINVAL; >> + >> +    if (val < 0 || val > TPDA_SYNCR_COUNT_MASK) > > Checking "val < 0" for an unsigned type is invalid. Simply keep the > second part. > Sure, sorry for the mistake. I forgot it’s an unsigned value here. Will send a new version to fix it. Thanks, Jie > Suzuki > > >> +        return -EINVAL; >> + >> +    guard(spinlock)(&drvdata->spinlock); >> +    drvdata->syncr_count = val; >> + >> +    return size; >> +} >> +static DEVICE_ATTR_RW(syncr_count); >> + >>   static struct attribute *tpda_attrs[] = { >>       &dev_attr_global_flush_req.attr, >> +    &dev_attr_syncr_mode.attr, >> +    &dev_attr_syncr_count.attr, >>       tpda_trig_sysfs_rw(freq_ts_enable, FREQTS), >>       tpda_trig_sysfs_rw(trig_freq_enable, FRIE), >>       tpda_trig_sysfs_rw(trig_flag_ts_enable, FLRIE), >> diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/ >> hwtracing/coresight/coresight-tpda.h >> index 1cc9253293ec..56d35697303a 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpda.h >> +++ b/drivers/hwtracing/coresight/coresight-tpda.h >> @@ -9,6 +9,7 @@ >>   #define TPDA_CR            (0x000) >>   #define TPDA_Pn_CR(n)        (0x004 + (n * 4)) >>   #define TPDA_FPID_CR        (0x084) >> +#define TPDA_SYNCR        (0x08C) >>   /* Cross trigger global (all ports) flush request bit */ >>   #define TPDA_CR_FLREQ        BIT(0) >> @@ -36,6 +37,11 @@ >>   /* Aggregator port DSB data set element size bit */ >>   #define TPDA_Pn_CR_DSBSIZE        BIT(8) >> +/* TPDA_SYNCR count mask */ >> +#define TPDA_SYNCR_COUNT_MASK        GENMASK(11, 0) >> +/* TPDA_SYNCR mode control bit */ >> +#define TPDA_SYNCR_MODE_CTRL_MASK    GENMASK(12, 12) >> + >>   #define TPDA_MAX_INPORTS    32 >>   /** >> @@ -52,6 +58,8 @@ >>    * @trig_freq:    Enable/disable cross trigger FREQ packet request >> interface. >>    * @freq_ts:    Enable/disable the timestamp for all FREQ packets. >>    * @cmbchan_mode: Configure the CMB/MCMB channel mode. >> + * @syncr_mode:    Setting the mode for counting packets. >> + * @syncr_count: Setting the value of the count. >>    */ >>   struct tpda_drvdata { >>       void __iomem        *base; >> @@ -66,6 +74,8 @@ struct tpda_drvdata { >>       bool            trig_freq; >>       bool            freq_ts; >>       bool            cmbchan_mode; >> +    bool            syncr_mode; >> +    u32            syncr_count; >>   }; >>   /* Enumerate members of global control register(cr) */ >> >