From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "Edgecombe@dev004.aci.vzint.dev" <Edgecombe@dev004.aci.vzint.dev>,
"aleksey.oladko@virtuozzo.com" <aleksey.oladko@virtuozzo.com>,
"x86@kernel.org" <x86@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"ptikhomirov@virtuozzo.com" <ptikhomirov@virtuozzo.com>,
"bp@alien8.de" <bp@alien8.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"tglx@kernel.org" <tglx@kernel.org>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>
Cc: "linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] selftests: x86: test_shadow_stack: return KSFT_SKIP when test is skipped
Date: Wed, 25 Mar 2026 20:57:50 +0000 [thread overview]
Message-ID: <2374231591e8c952437a5dad68fd4b82e68fcc0b.camel@intel.com> (raw)
In-Reply-To: <75496499-9ceb-449c-8a73-30d9ea1cc452@virtuozzo.com>
+Jiri who added this part of the test
Link:https://lore.kernel.org/lkml/20260323104536.198738-1-aleksey.oladko@virtuozzo.com/
On Mon, 2026-03-23 at 12:15 +0100, Pavel Tikhomirov wrote:
> > type = determine_uprobe_perf_type();
> > if (type < 0) {
> > - if (type == -ENOENT)
> > + if (type == -ENOENT) {
> > printf("[SKIP]\tUretprobe test, uprobes are not
> > available\n");
> > - return 0;
> > + return 0;
> > + }
> > + return 1;
> > }
This patch looks good and thanks for fixing up the other stuff. Except I'm not
sure if this whole < 0 scenario would be better to leave as a skip. The failure
to read the file isn't testing anything about shadow stack. So I'd leave the
existing behavior, or if you want to improve it, drop the type == -ENOENT check
and just always print SKIP and return 0.
Jiri do you recall why it only prints SKIP in the -ENOENT case?
prev parent reply other threads:[~2026-03-25 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 10:45 Aleksei Oladko
2026-03-23 11:15 ` Pavel Tikhomirov
2026-03-25 20:57 ` Edgecombe, Rick P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2374231591e8c952437a5dad68fd4b82e68fcc0b.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=Edgecombe@dev004.aci.vzint.dev \
--cc=aleksey.oladko@virtuozzo.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®