From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754861AbcBBMxW (ORCPT ); Tue, 2 Feb 2016 07:53:22 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:61884 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764AbcBBMxU (ORCPT ); Tue, 2 Feb 2016 07:53:20 -0500 From: Arnd Bergmann To: zengtao Cc: tglx@linutronix.de, fweisbec@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cputime: Fix timeval/timespec-->cputime conversion Date: Tue, 02 Feb 2016 13:53:01 +0100 Message-ID: <2375212.i4Z9u5Ytcc@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1454384314-154784-1-git-send-email-prime.zeng@huawei.com> References: <1454384314-154784-1-git-send-email-prime.zeng@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:/hW7lHLPNqY+/nAxA2sc4sj3z/Za7/lv2udqG08IlWv3tfaDY+e Rmn5WzRLl6yb0BR0MIGdC9T7KcS/9KQauyK7sZGRyxXqo7EW8lbM7PJtkHetizGQLXCi28a bzIVco0PjGjqohNYpe9ntAzMKFLaeX+f8aArbUYVX+gw+kaQ0r++/V3ZrbtVW/i/Mpe36q4 dkwfHftO3qc0PLlQDC5QA== X-UI-Out-Filterresults: notjunk:1;V01:K0:9Z2XrZ5yBWk=:fij3KIlR3EQcsUt3RYSrIA GJz+9CYHfRb9lzOspXRX/NR5kgy+OeH3XcegAwvZu6Jp8uS/qMPHqojqhCUKqllaAXcnfnbJg dlfCYXdqggH6rqDX4J7jS3+i1yalflIAofkHZro4vvT0Bs1DrTfGGBbLjObEQSsZcAcu7HYMq vqjbzSJo90pSN9vFZyI17/ADvRs6dS2eCgbtWXGqouj6RX1cQv1UTctqUfjQz11QaQYJt78W2 wREgzQWP9KclIE3S79aCScGUrlOb621CVT5payzFF94wqUfb4nNSBQS4QGvkChUhzfU8KLYfL A54+dflUXypEkU9St3hGPAO/E6gH+k7Nps4nqFCeM1RyR6YdOgZbMP3h6/voJTCZA07yxGzbA Jv7ST5gWeUB47UMWUAMnyzNppYVpUU7gsgRJLp4bJf5rBCcShgv2GgGCpzRKR7n6rGPm83qFZ KhfSr1Kk/WKqZ8RfE2si5gSUkRsMaB5mg8drcwzAT2/ymKT/1ys2f2Cg3Sy0CmTmjYnS7lotK fJ2eRN+9mzbK2HgqB3kM339qfYrV4zxzUfOG7dX6vXOAIBl8T3hNUePSeYqsgLNMLY0flFQkN Xw8MdbaPQMSIBfgIcOaVSwuI9e2QdBGrj6GOoHjOzbbVaQ8JKuIX5IruvPyPu7PgK50QzHxv1 Nf2qsqVDbrAqet87Ch6/G7VmVg1nJByR/e7JQpAn9xsTbcqOG+vJWaIXwl939cHGAdhmjd47s nf4PcAksq1jUjgkN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 02 February 2016 11:38:34 zengtao wrote: > The datatype __kernel_time_t is u32 on 32bit platform, > it will easily get overflow, so force u64 conversion. > > Currently the following function will be affected: > 1. setitimer() > 2. timer_create/timer_settime() > 3. sys_clock_nanosleep > And this will occur on MIPS32 and ARM32 with "Full dynticks CPU > time accounting" enabled, which is required for CONFIG_NO_HZ_FULL. > > Signed-off-by: zengtao > The patch looks good now, but please add a line saying Fixes: 31c1fc818715 ("ARM: Kconfig: allow full nohz CPU accounting") below your Signed-off-by, so everyone can figure out whether they need this backported or not. Reviewed-by: Arnd Bergmann Thomas, do you want to take this through the tip tree?