From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4207C433F5 for ; Thu, 28 Apr 2022 07:44:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245676AbiD1Hrk convert rfc822-to-8bit (ORCPT ); Thu, 28 Apr 2022 03:47:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239176AbiD1Hri (ORCPT ); Thu, 28 Apr 2022 03:47:38 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBFA49D053 for ; Thu, 28 Apr 2022 00:44:24 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njyol-0002pJ-Gl; Thu, 28 Apr 2022 09:44:03 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1njyoj-005iCw-PE; Thu, 28 Apr 2022 09:44:00 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1njyoh-0002VQ-OH; Thu, 28 Apr 2022 09:43:59 +0200 Message-ID: <23757fe6843e56b91a87d60eb0782ec6b64c10fd.camel@pengutronix.de> Subject: Re: [PATCH 2/5] iommu/sun50i: Support variants without an external reset From: Philipp Zabel To: Samuel Holland , Joerg Roedel , Will Deacon , iommu@lists.linux-foundation.org Cc: Heiko Stuebner , Palmer Dabbelt , linux-riscv@lists.infradead.org, Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Date: Thu, 28 Apr 2022 09:43:59 +0200 In-Reply-To: <20220428010401.11323-3-samuel@sholland.org> References: <20220428010401.11323-1-samuel@sholland.org> <20220428010401.11323-3-samuel@sholland.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Samuel, On Mi, 2022-04-27 at 20:03 -0500, Samuel Holland wrote: > The IOMMU in the Allwinner D1 SoC does not have an external reset line. > > Only attempt to get the reset on hardware variants which should have one > according to the binding. And switch from the deprecated function to the > explicit "exclusive" variant. > > Signed-off-by: Samuel Holland Reviewed-by: Philipp Zabel regards Philipp