mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Cong WANG" <xiyou.wangcong@gmail.com>
To: "Jan Engelhardt" <jengelh@linux01.gwdg.de>, linux-kernel@vger.kernel.org
Subject: Re: Style Question
Date: Mon, 12 Mar 2007 13:37:43 +0800	[thread overview]
Message-ID: <2375c9f90703112237u4b27c530x34e310a93fd04ef0@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0703112134180.16857@yvahk01.tjqt.qr>

2007/3/12, Jan Engelhardt <jengelh@linux01.gwdg.de>:
>
> On Mar 11 2007 22:15, Cong WANG wrote:
> >
> > I have a question about coding style in linux kernel. In
> > Documention/CodingStyle, it is said that "Linux style for comments is
> > the C89 "/* ... */" style. Don't use C99-style "// ..." comments."
> > _But_ I see a lot of '//' style comments in current kernel code.
> >
> > Which is wrong? The documentions or the code, or neither? And why?
>
> The code. And because it's not always reviewed but silently pushed.
>
> > Another question is about NULL. AFAIK, in user space, using NULL is
> > better than directly using 0 in C. In kernel, I know it used its own
> > NULL, which may be defined as ((void*)0), but it's _still_ different
> > from raw zero.
>
> In what way?

The following code is picked from drivers/kvm/kvm_main.c:

static struct kvm_vcpu *vcpu_load(struct kvm *kvm, int vcpu_slot)
{
       struct kvm_vcpu *vcpu = &kvm->vcpus[vcpu_slot];

       mutex_lock(&vcpu->mutex);
       if (unlikely(!vcpu->vmcs)) {
               mutex_unlock(&vcpu->mutex);
               return 0;
       }
       return kvm_arch_ops->vcpu_load(vcpu);
}

Obviously, it used 0 rather than NULL when returning a pointer to
indicate an error. Should we fix such issue?

>
> >So can I say using NULL is better than 0 in kernel?
>
> On what basis? Do you even know what NULL is defined as in
> (C, not C++) userspace? Think about it.
>

I think it's more clear to indicate we are using a pointer rather than
an integer when we use NULL in kernel. But in userspace, using NULL is
for portbility of the program, although most (*just* most, NOT all) of
NULL's defination is ((void*)0). ;-)

  parent reply	other threads:[~2007-03-12  5:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-11 14:15 Cong WANG
2007-03-11 14:22 ` Bernd Petrovitsch
2007-03-11 20:35 ` Jan Engelhardt
2007-03-11 20:41   ` Daniel Hazelton
2007-03-11 22:01     ` Kyle Moffett
2007-03-11 23:16       ` Jan Engelhardt
2007-03-12  1:27         ` Kyle Moffett
2007-03-12  1:32           ` Jan Engelhardt
2007-03-12  1:43             ` Kyle Moffett
2007-03-12  5:37   ` Cong WANG [this message]
2007-03-12  5:40     ` Jan Engelhardt
2007-03-12  5:52       ` Nicholas Miell
2007-03-12  6:18       ` Randy.Dunlap
     [not found]       ` <MDEHLPKNGKAHNMBLJOLKOEBCCDAC.davids@webmaster.com>
2007-03-12 13:52         ` Cong WANG
     [not found] <fa.Da+t1e9MgP7HaKS+dOWXVD8aYNI@ifi.uio.no>
2007-03-11 15:47 ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2375c9f90703112237u4b27c530x34e310a93fd04ef0@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®