From: "Cong WANG" <xiyou.wangcong@gmail.com>
To: "Pedram M" <pmessri@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: submitting kernel janitorials
Date: Sat, 31 Mar 2007 21:52:30 +0800 [thread overview]
Message-ID: <2375c9f90703310652w284dc313obb579b2b0dc62c76@mail.gmail.com> (raw)
In-Reply-To: <9c9aa5d00703310640m6f4cf55aidc3cba706a8d3bff@mail.gmail.com>
2007/3/31, Pedram M <pmessri@gmail.com>:
> Ok thanks,
>
> I've sent one already, could you please double check:
>
> @@ -4590,7 +4590,7 @@
> printk("stli_findpcibrds()\n");
> #endif
>
> - while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION,
> + while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION,
> PCI_DEVICE_ID_ECRA, dev))) {
> if ((rc = stli_initpcibrd(BRD_ECPPCI, dev)))
> return(rc);
>
>
> That as an example for file:
>
> drivers/char/istallion.c
>
>
> Thanks,
> Pedram
Why did you delete the list? Please don't do that.
In fact, I am a newbie too. I know pci_find* functions are deprecated
and gcc will warn that. And I think we should replace them. You can
try to make patches for them and submit them to Greg. (Greg, is that
OK?)
--
So Dark The Con Of Man.
next prev parent reply other threads:[~2007-03-31 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-31 13:27 Pedram M
2007-03-31 13:37 ` Cong WANG
[not found] ` <9c9aa5d00703310640m6f4cf55aidc3cba706a8d3bff@mail.gmail.com>
2007-03-31 13:52 ` Cong WANG [this message]
2007-03-31 17:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2375c9f90703310652w284dc313obb579b2b0dc62c76@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmessri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®