mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] setup_affinity return 1 with failure
Date: Mon, 15 Jun 2009 11:20:25 +0800	[thread overview]
Message-ID: <2375c9f90906142020j74dd3849mc53cc7399ae4243c@mail.gmail.com> (raw)
In-Reply-To: <2674af740906140833h608ffdefj746096af3a559876@mail.gmail.com>

On Sun, Jun 14, 2009 at 11:33 PM, Yong Zhang<yong.zhang0@gmail.com> wrote:
> setup_affinity should return 1 when failure, then make checking in
> irq_select_affinity_usr() reasonable.
>
> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>

Looks good.

Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

> ---
>  kernel/irq/manage.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index aaf5c9d..8d2a992 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -137,7 +137,7 @@ int irq_set_affinity(unsigned int irq, const
> struct cpumask *cpumask)
>  static int setup_affinity(unsigned int irq, struct irq_desc *desc)
>  {
>        if (!irq_can_set_affinity(irq))
> -               return 0;
> +               return 1;
>
>        /*
>         * Preserve an userspace affinity setup, but make sure that
> --
> 1.6.0.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

      reply	other threads:[~2009-06-15  3:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-14 15:33 Yong Zhang
2009-06-15  3:20 ` Américo Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2375c9f90906142020j74dd3849mc53cc7399ae4243c@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®