From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Borislav Petkov <borislav.petkov@amd.com>
Cc: Jean Delvare <khali@linux-fr.org>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
x86 <x86@kernel.org>, Doug Thompson <norsk5@yahoo.com>,
linux-kernel@vger.kernel.org
Subject: Re: [origin tree build failure] Re: [GIT PULL] AMD64 EDAC updates, p1
Date: Wed, 16 Sep 2009 17:41:57 +0800 [thread overview]
Message-ID: <2375c9f90909160241o8a208d9jb13b1edb0576ade7@mail.gmail.com> (raw)
In-Reply-To: <20090915145923.GC3824@aftab>
On Tue, Sep 15, 2009 at 10:59 PM, Borislav Petkov
<borislav.petkov@amd.com> wrote:
> On Tue, Sep 15, 2009 at 04:38:37PM +0200, Jean Delvare wrote:
>> On Tue, 15 Sep 2009 13:09:40 +0200, Ingo Molnar wrote:
>> > -tip testing found this build failure with the attached config:
>> >
>> > drivers/edac/edac_mce_amd.c: In function ‘decode_mce’:
>> > drivers/edac/edac_mce_amd.c:408: error: ‘per_cpu__cpu_llc_id’ undeclared (first use in this function)
>> > drivers/edac/edac_mce_amd.c:408: error: (Each undeclared identifier is reported only once
>> > drivers/edac/edac_mce_amd.c:408: error: for each function it appears in.)
>> >
>> > I did the patchlet below but this needs a cleaner fix eventually. A
>> > proper node abstraction needs to be factored out and provided as a
>> > facility regardless of config settings.
>> >
>> > Ingo
>> >
>> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
>> > ---
>> > drivers/edac/edac_mce_amd.c | 5 ++++-
>> > 1 file changed, 4 insertions(+), 1 deletion(-)
>> >
>> > Index: linux2/drivers/edac/edac_mce_amd.c
>> > ===================================================================
>> > --- linux2.orig/drivers/edac/edac_mce_amd.c
>> > +++ linux2/drivers/edac/edac_mce_amd.c
>> > @@ -405,8 +405,11 @@ void decode_mce(struct mce *m)
>> > regs.nbsh = (u32)(m->status >> 32);
>> > regs.nbeal = (u32) m->addr;
>> > regs.nbeah = (u32)(m->addr >> 32);
>> > +#ifdef CONFIG_X86_HT
>> > node = per_cpu(cpu_llc_id, m->extcpu);
>> > -
>> > +#else
>> > + node = 0;
>> > +#endif
>> > amd_decode_nb_mce(node, ®s, 1);
>> > break;
>> >
>>
>> FWIW, this patch doesn't fix the problem for me. Amerigo Wang's does:
>> http://lkml.org/lkml/2009/9/15/64
>
> We'll have an even better fix soon:
> http://marc.info/?l=linux-kernel&m=125302459621925
Yeah, agree.
next prev parent reply other threads:[~2009-09-16 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 17:19 Borislav Petkov
2009-09-15 11:09 ` [origin tree build failure] " Ingo Molnar
2009-09-15 13:29 ` Borislav Petkov
2009-09-15 14:38 ` Jean Delvare
2009-09-15 14:59 ` Borislav Petkov
2009-09-16 9:41 ` Américo Wang [this message]
2009-09-15 11:59 ` [origin tree build failure] [PATCH] Fix: amd64_edac.c:(.text+0x3e9491): undefined reference to `amd_decode_nb_mce' Ingo Molnar
2009-09-15 13:25 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2375c9f90909160241o8a208d9jb13b1edb0576ade7@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=norsk5@yahoo.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®