From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Dave Jones <davej@redhat.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
kraxel@bytesex.org, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix argument order in memset call in ./drivers/media/common/ir-functions.c
Date: Thu, 12 Nov 2009 15:09:17 +0800 [thread overview]
Message-ID: <2375c9f90911112309xcf76517kb5976cb4b0394102@mail.gmail.com> (raw)
In-Reply-To: <20091111215928.GA25154@redhat.com>
On Thu, Nov 12, 2009 at 5:59 AM, Dave Jones <davej@redhat.com> wrote:
> Size is the third argument, not the second.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
Definitely yes.
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> diff --git a/drivers/media/common/ir-functions.c b/drivers/media/common/ir-functions.c
> index 655474b..abd4791 100644
> --- a/drivers/media/common/ir-functions.c
> +++ b/drivers/media/common/ir-functions.c
> @@ -64,7 +64,7 @@ void ir_input_init(struct input_dev *dev, struct ir_input_state *ir,
>
> ir->ir_type = ir_type;
>
> - memset(ir->ir_codes, sizeof(ir->ir_codes), 0);
> + memset(ir->ir_codes, 0, sizeof(ir->ir_codes));
>
> /*
> * FIXME: This is a temporary workaround to use the new IR tables
prev parent reply other threads:[~2009-11-12 7:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 21:59 Dave Jones
2009-11-12 7:09 ` Américo Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2375c9f90911112309xcf76517kb5976cb4b0394102@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=davej@redhat.com \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®