Re: [PATCH] scripts/kallsyms build warning fix

["Américo Wang" <xiyou.wangcong@gmail.com>]

On Tue, Jan 26, 2010 at 5:41 AM, Himanshu Chauhan
<hschauhan@nulltrace.org> wrote:
> Hi all,
>
> This is a small patch that fixes the build warning
> of scripts/kallsyms.c
>
> Regards
> Himanshu
>
> Signed-off-by: Himanshu Chauhan <hschauhan@nulltrace.org>
> ---
>  scripts/kallsyms.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 86c3896..e3902fb 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -108,8 +108,10 @@ static int read_symbol(FILE *in, struct sym_entry *s)
>        rc = fscanf(in, "%llx %c %499s\n", &s->addr, &stype, str);
>        if (rc != 3) {
>                if (rc != EOF) {
> -                       /* skip line */
> -                       fgets(str, 500, in);
> +                       /* skip line. sym is used as dummy to
> +                        * shut of "warn_unused_result" warning.
> +                        */
> +                       sym = fgets(str, 500, in);
>                }
>                return -1;
>        }

Why not use the return value to do some useful checking?