From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2DF6C04A94 for ; Fri, 28 Jul 2023 09:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235112AbjG1JDJ (ORCPT ); Fri, 28 Jul 2023 05:03:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235100AbjG1JCr (ORCPT ); Fri, 28 Jul 2023 05:02:47 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5F252D5E; Fri, 28 Jul 2023 02:02:43 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 27C6624E31A; Fri, 28 Jul 2023 17:02:40 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 28 Jul 2023 17:02:40 +0800 Received: from [192.168.120.59] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 28 Jul 2023 17:02:39 +0800 Message-ID: <23769fc1-69cb-f237-6488-f2322368e309@starfivetech.com> Date: Fri, 28 Jul 2023 17:02:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI Content-Language: en-US To: Conor Dooley CC: , , , , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" , Ziv Xu References: <20230719092545.1961401-1-william.qiu@starfivetech.com> <20230719092545.1961401-3-william.qiu@starfivetech.com> <20230728-retread-starch-3399b921718a@wendy> From: William Qiu In-Reply-To: <20230728-retread-starch-3399b921718a@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/28 16:58, Conor Dooley wrote: > Hey William, > > Since you pinged things, I had a quick look. > > On Wed, Jul 19, 2023 at 05:25:44PM +0800, William Qiu wrote: >> Add JH7110's clock initialization code to the driver. >> >> Signed-off-by: William Qiu >> Reviewed-by: Hal Feng > >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202306022017.UbwjjWRN-lkp@intel.com/ >> Reported-by: Julia Lawall >> Closes: https://lore.kernel.org/r/202306040644.6ZHs55x4-lkp@intel.com/ > > These, as pointed out on the last version, should not be here. > kernel test robot complaints about un-applied patches do not get a > reported-by etc in subsequent versions of the same patchset, just as > comments from human reviewers do not require reported-by tags. > > These tags should only be used when the code has been merged & you need > to create a new patch to fix the issue. > > Hopefully, if the code is otherwise fine, Mark can fix this when he > applies the patches. > > Thanks, > Conor. Hi Conor, Fine, I will drop it in next version. Best regards, William