From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752995AbdLHSJi (ORCPT ); Fri, 8 Dec 2017 13:09:38 -0500 Received: from mout.web.de ([212.227.15.3]:64553 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbdLHSJe (ORCPT ); Fri, 8 Dec 2017 13:09:34 -0500 Subject: [PATCH 1/4] serial: pch_uart: Delete an error message for a failed memory allocation in dma_handle_tx() From: SF Markus Elfring To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <2378ba53-4894-e532-7523-b578e42c8eb2@users.sourceforge.net> Date: Fri, 8 Dec 2017 19:09:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:8dL67qGP9EdzqbCAYsznhAjIoEv1WyAEvN36iwojasqrrAS+Bp7 +3KySrcMt3/dwBmoj+uKuxUG2EdfRyhBR6uSvqTTMuELtQ9c2N1Dz2/Pg1gpIdOVOtc13pz NzBjlNodPimSBWmR+9zGfDxRHaKuateQx7J5D8J8Y/EinP+NXSFZb4VfNDWiVSVG9Jb7SKm B6v8xIiNJV6jwx2i627OQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:GSINyPp1vFE=:l1kH/zB0FYaw3YmU9Ga0z/ AhfHxGMsKEBDj6OCRe8eCWYGdBNw3+J84BMKrKFt+pnlqPped//go5JhFtziPYC+qU/rtpIGN 1/B1LaB+7x2CWxR/Ijmph5Y99DtB+8uEjxmTOuxSWZxiS7aUMj8Nl7rneAboaczyOSUKgN9IY qGgdaXDHNaJBm4QeSpZtpj7UsROTNBLkjnwkD3YlqLsKhbIib6URntDIbupR54rTs5EAbs6ab LZw87yMqVhWf2XXZvcWJo1AOW/9iucikEDx7OBtDo389li387hPu3LdwGwmYvMHmDZe60RdTQ FGcZE9JxEvbbzViHzQ0e7iQC2fNE+5Rz420xzL10fiWO5/zI2NSpp0CMw5PXWphKEKVkw89Bt nlphu50r6Herb07jE9zIcBjuOnoUGOemiXhTl6Fy0N6KR9D9P6blTVjwivuTAZyTrBUaBKtx1 jv5PNr4eUiLxnAdepCGuGBNEX8ctG7hLl0HEWuxYm8yg+piOxvrEN/+056eLgfrldtAvah8sx ieyPCq3Yxdk7zGOSozeH1uNUISTjMDkC1RYNUpkef7mopkXfhLNBvNHQ4EVVdnfYkUuCwrBFN wwndstU6AO4QUmyD2egT/1pe2xH4mjw5kDsg+nfU0cJFKKrCMtSkdMhPFFonVJT7RUiXJCSU7 LYdt15sc2JjQ0lsliqVlIlS4S35D8RL+Z41/1JqEe4z+zAvRpuL77tx2cmikcKbiIUOt5QGCM 7h2wYS0kIpTmfqVAZ8RbnZxfHbWeoTiqhGZRF8FMbyZ3vuVTRJKqDVVEMk1HKDuOrjj00pJZ5 loij8Ot0afUMXxzxFirXHQzfQ9TXJ5dyn5FRqdj4S2ES9XLM/s= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 8 Dec 2017 18:28:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/pch_uart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 760d5dd0aada..0fc72c491c9b 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -992,10 +992,8 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv) priv->tx_dma_use = 1; priv->sg_tx_p = kzalloc(sizeof(struct scatterlist)*num, GFP_ATOMIC); - if (!priv->sg_tx_p) { - dev_err(priv->port.dev, "%s:kzalloc Failed\n", __func__); + if (!priv->sg_tx_p) return 0; - } sg_init_table(priv->sg_tx_p, num); /* Initialize SG table */ sg = priv->sg_tx_p; -- 2.15.1