From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbdHPTWn (ORCPT ); Wed, 16 Aug 2017 15:22:43 -0400 Received: from mout.web.de ([212.227.17.12]:60429 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbdHPTWj (ORCPT ); Wed, 16 Aug 2017 15:22:39 -0400 Subject: [PATCH 2/3] pstore: Improve a size determination in three functions From: SF Markus Elfring To: Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck , kernel-janitors@vger.kernel.org Cc: LKML References: <97737d95-d6aa-d24f-1af0-9d4895ceaed2@users.sourceforge.net> Message-ID: <23798ef4-5559-3454-ecf4-e6844b644ff3@users.sourceforge.net> Date: Wed, 16 Aug 2017 21:22:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <97737d95-d6aa-d24f-1af0-9d4895ceaed2@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:oJ9lZBJJ8qwjEVUfK35b4ojoGyl3ve70nd/+Cn0IW+vx5v/l2fD WeMWiei/igVIFE8TlJrBuVyKsW0aeK4TC1psLPfnrm51L65TjwRmdeAXip1GscQ9l7WkHFD 6yn+kYngPF4V0X4GYtR+sj24OGXA7PuUfY3Npp1Y48l2hF2ZCCBg1rOo0rs6jIS8IzzYWCS Al22l7bjXMQraTSsZp7Lw== X-UI-Out-Filterresults: notjunk:1;V01:K0:iTgBxYJ0WZw=:Efbl4FIMdrdc8hpHUhwmAD vrHeq4AbofCrDq/vc8hxlsEHwLTtUMXQeoSF3EeP+qLx396BwkkWjsMm1z2lLukekc7G1uQBp 4yw1pFTzrW+c9NaJeqsDSG65phEEyjucO0U0Gx14s8RsN94Bx+NbMrQsE5R8vvjyWn+mNzXB7 k/Xkb7/bdWiCByIAu0ujbfU4EjPEfbTnVGjO2ud+dStN8KkAyztzhFZY41wkK+wXH62By7W2n cjisFpehgg8/xpACETGshJD3j4lnr13ieJ/BtxzW+686cFC+jTX98DTQ/7oa+gqIa/HDkWZvs T9m16CaozX0j39c8n0j8Nho5fVJKYgpTNnnvxSv3feVpUKvi8/tZa7xs7n5+Hd8CTzYbDutTO DBLuvu7DY8T+TKcxQ3KivWjvE/J+cKto/wJxxLos9h2G1nGYOOwufT0opm2YGhaCjQ8U+NFWl TYJmip7dHpOWO/I1TOL9R65kARxMpAsDbWnPPHliDNkueAji52JUW0iqODEu6bGOdcUBB8sMN gudrJoqIdt2euledyDXO8a3P1/gec6elHOcblD5ypmen9hOFj4pMIUUuiE8n0S6riZ8IBNI8O gsvKCVS1oSGpaMQGjeGQTiU47Ah2o+3To8ULeITDtA6adfZeYdLBZHtzGKOyFu1es0xK3vgpR l39ug/vxl/213f5c8C1TksgzqQhgUVykFICY4rkJZ8+e5qHM0Wenp9niJN9VigWYZcavkhlvh lWKV6FT8BusQ8EFe0tCxTRn2OfA44K31Llatj+UQ4XBAz900XbOn0pGgCbeZRPy6vFfgS1ZJo V+ry/pZ4Wwt/CqfZbsvKGBUMzFnAf8HlQMLp+Z9Om2f0YXk5sQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 16 Aug 2017 20:50:15 +0200 Replace the specification of data types by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/pstore/ram.c | 3 +-- fs/pstore/ram_core.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 42d27e5fac9f..0ef95c384bed 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -293,8 +293,7 @@ static ssize_t ramoops_pstore_read(struct pstore_record *record) */ struct persistent_ram_zone *tmp_prz, *prz_next; - tmp_prz = kzalloc(sizeof(struct persistent_ram_zone), - GFP_KERNEL); + tmp_prz = kzalloc(sizeof(*tmp_prz), GFP_KERNEL); if (!tmp_prz) return -ENOMEM; free_prz = true; diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index fafa8af1289c..5d9f7280d757 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c @@ -405,7 +405,7 @@ static void *persistent_ram_vmap(phys_addr_t start, size_t size, else prot = pgprot_writecombine(PAGE_KERNEL); - pages = kmalloc_array(page_count, sizeof(struct page *), GFP_KERNEL); + pages = kmalloc_array(page_count, sizeof(*pages), GFP_KERNEL); if (!pages) return NULL; @@ -520,7 +520,7 @@ struct persistent_ram_zone *persistent_ram_new(phys_addr_t start, size_t size, struct persistent_ram_zone *prz; int ret = -ENOMEM; - prz = kzalloc(sizeof(struct persistent_ram_zone), GFP_KERNEL); + prz = kzalloc(sizeof(*prz), GFP_KERNEL); if (!prz) goto err; -- 2.14.0