From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011035.outbound.protection.outlook.com [40.107.208.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59C936604B for ; Sat, 25 Apr 2026 14:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.35 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777126883; cv=fail; b=pevm21Ktt1II6DL7L/oE4SzM9vnRg3jUyBt+eE1bYQEMeNv4s0L02zZGQCLT0DLW/0Yq2jJxHkknyfeilxqbqNymh7xlecpEM4TFolAho0AIBa+o2q2o7HiHMCRL7IbAxm+OD5+l0mSqBHfrvSxj5PufKyI0WPOHvixu7qv9K/A= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777126883; c=relaxed/simple; bh=ifvy3IpXdXGf5w9xNyPlonHIQbpojrZ4JzOUlAT923Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=VrmtsXbF8KQApdYis+jPufMM8NLenqcuNV79M3ZRJ0yhSyCiSTEduhJGUEgOYoZLH//WW/a7/CWmYkNuQUkUew88JW/7kLPvyIRAstIHXVpCQ9icMnlH1VHBe05393GoGrcaYL87iyYXPvBLQ2ZwFWIh7XUFBAzuY59N7ynQ/rM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=HF3WPghQ; arc=fail smtp.client-ip=40.107.208.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="HF3WPghQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JKD5YImN7puU4+o94SJjn4doz8nOn8w/DWPSd8q4172VxfDCq3pqN7MTShBhRPYdRlj9qyBE52Qk8isplWAkMi145M1I9Kfl4KUYDot84Ak/SF877keNiK0SzTg9gQrx3R4WNXkZ+dtfb1nI5x9f9GK9shJNDDh0F5U+T+xC+TYP3iUUeRNZP1bNJgH4pKLuog2CRt34uSz6vCiN7rEu+IzjX3HnVYw+F9/BLWK/au0bT8dvggD2aeuSbG16ayziKgowfwG034og8buxFW3IU0GjPJ/1iVP36IZcZ7ZESOU9WJXkR70+U1ol9CTwHiJynh+6js2QjU79iU8ToK5BqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=maDg5RY4I9HU8J6iycHzyrWnoRsULlur5AeJpegaKng=; b=eGcGPQIKtybU2hPDa4/z9Yu0RVsmaHrs5oE8qXaQs57PechbmZbb7bMVsdYoKLlHl5Z3q0Lr2CkfEV32wm+qEBobNJCyvDZ4hf+Uj3O+76yM5vy0FHtny0ix4EY49CnBNOSV1yqy7K43lx5+qhOoK7l+q8ljXNpdmMpgGVhckxzvFZoaH02/3fC0fnEkTJnpE7EtSAafi8hbnWAjEYtAzYWeFOfSkG8JxiAMuOJTYKTO7AEhiaNSv5Jddufddm7BUlo25cbO18UUEV1JLgLFMWG7LohdPvTr/9ecGKafp2C6KVC9F243mRCxRwjNQyYTJSn/bgHLxvA2BTIQwFhwLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=maDg5RY4I9HU8J6iycHzyrWnoRsULlur5AeJpegaKng=; b=HF3WPghQRtNLSGB+En+hw4vA0Joe//MXNiO3zLaUIuwj5fLIeuiYDVkPS58IxKgRV1V/H4gkX34c/8HKjqYNUO5JOj8eIEXbrqtfVviC1cL0liwrsJJoi+AkW6u10hFxyKSfcY5he2MUQ1r41PAfXvDW7QNJ+Udvp5c4wkIWAoKX2vkh8f8t7DQWSu1yqJw6chiX6eplY2bIx9f1tVMLw9q3jS0RgtYW4XgnWqLIpUL33ly33t48l9QKwavq6IpWoTt47h6BNkqEYyYHMf1Fhh9kwjBFQCfW5/iNspcEkOTRp5sr7VHmic6fbXnprMzr6peDLVBU2Szx1zCjGjuc+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SJ0PR12MB7035.namprd12.prod.outlook.com (2603:10b6:a03:47c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.12; Sat, 25 Apr 2026 14:21:18 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9846.021; Sat, 25 Apr 2026 14:21:18 +0000 From: Zi Yan To: Sunny Patel Cc: Andrew Morton , David Hildenbrand , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/migrate_device: fix spinlock leak in migrate_vma_insert_huge_pmd_page Date: Sat, 25 Apr 2026 10:21:17 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: <23799334-DD7F-4301-B361-8543C203E25A@nvidia.com> In-Reply-To: <20260425133537.17463-1-nueralspacetech@gmail.com> References: <20260425133537.17463-1-nueralspacetech@gmail.com> Content-Type: text/plain X-ClientProxiedBy: IA1P220CA0014.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:464::8) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SJ0PR12MB7035:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ea261e4-f415-483a-979b-08dea2d5eaea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: A8HbYM9rs7/DwbDwzH+ASdCfDvXQ8dHDKD/00j7vSwkLwFMtvQ0euKdb1bWkjmtIJlwvsbsmhknJCw/xf+op+dJguagkCSSUYPU85+0FunDenXFiH47QPC4rEZfuGE80mk32DtCMFFUCKZW3IFwFmyc0uZfUMBcfgk+hJpJX/y7ZMS5bBYyUzaqH2B0QrcxWE5ByyDNHoIJj+EwsKm+mPZUX1UUiPQKwiPbgrBE6ApTb01Eyc4f7Ic6yUlr+jj8xY3FekS6bBes3qlWDYRwJN2ORp2Xa60r5KrltOUWT+OCZkg6bxJ0162cwClNBOs7gUsg+uBjXj2nuXFxHiQqy9F2vbhbaEd2GsERcZcO4s/B/jqcR7aTRmLJ0We61asYRrqGQSXFTNV/83CiPwFaTEzimPja/EbWBjjCBX5EX1FhAL3qzmlHPHfFlkU5YDj6TJaos4bwquUu4hmRFzo//tOOtKFAd+j0vLdYS9ZIV1DBWXSg2FePk46hiX0RE7Em9FDhG0DhSnA5IvEnEzeS+JKeHBG5SxIvE8e30cBaBvuO0n/gqVp2fgXJY1Q/fq7iKnWoNdcprXu0i0Cs4i7dk3rNaeO2GX56ujJLuTJFHKrxk4+PgM9yaJi/luFI1GcKPrR89OSP6njNaFpOq4GX+BIT19sFXazBAgqaoMXV+cmkV6WgT333mpmvtUI/NnSw3DOf5FdIx5to9B8pbYGEV1GIHYOnTIduH7KfVZ0jEJnM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l5+T0oqKnxMTTVmqWtJEzB5gPYWR8rHRv/wIGPPmDoPOr1JNstXCI/pGkVyg?= =?us-ascii?Q?Qk9Gy1RWhWB4Jzfc6Es3+qwZ2AicS3KK1Q96mlgbYN05ZjTzmXLKx+zDNILS?= =?us-ascii?Q?GaAR0AN1FuVZ57qqvs+Y8f3vSctJWppGhCrfWETOJPvEyWelvzBQBL5YhsN6?= =?us-ascii?Q?XV2aRso1dewXQvynBes9Acw96Bkrz/LOwE//LnFY2NHtWv4P0bKw1idlmYxl?= =?us-ascii?Q?8VTLw7NFsxyPYcwruVHd3Pm4wmJKNcAVvU53d6enzd1SHeAbdOyOBRFFSJXt?= =?us-ascii?Q?CnMm2o9nfzm3IhlVFrZ584SzxnifC4/rUQiil5VnNm3TM32f95O11pyiGdBO?= =?us-ascii?Q?+V44eob2A4KF1twbhye7AB3O41qA/gEtRfHPbai1DHWf4tROBqA8uYUv+jzi?= =?us-ascii?Q?Qfkxdbl6aJzz9GkBpWvxWaJUmiNOOTEeyHoqhJZOEn9D2u8lWS+7i/TfqzOA?= =?us-ascii?Q?smqeNS6x8ycvLBgmm+REWPfpCFYC6ljyYlLq9JAh/nyRCs+bAHjvmB+e4Guy?= =?us-ascii?Q?yFtr4UQiLJkXtvcGLasie0f8W3B3crls4CtOzIO2gqHrnsRGvjHK6Uc84MVx?= =?us-ascii?Q?MBAkcdIQAhUqefr9upNJAmyx8Ae/hsOHZBqMyhEeAZSYoTPkr0iYUtl0a1CV?= =?us-ascii?Q?yOnCIpFo/EC2DtFjZuGOPtvV7uyAQMDTcTprdYJcWJ+J6/A1DqiZBnp2Nlte?= =?us-ascii?Q?pdVsgDa2fcXIXHKI/XCwRpPmaWaVIepVXk7KUy9K5LoR8inWT0108N9Y0rjc?= =?us-ascii?Q?cMXR4KFOInOfNP4QP8ebQL3H59vOiuVC1uUMvLlryHYXUSZWuaXoY9QNbTAx?= =?us-ascii?Q?Qvnqt+utMynZ8wDRJEGZFud6EWB+zfiLkBlY8yWmbMJvkp/86ish1MomsC83?= =?us-ascii?Q?kADNOdk0IjcAc/gkRnoLIjrp66cNbXJQAaXEl1PGjuNZY7yovYe5M/5jRBUf?= =?us-ascii?Q?AI5UceqCgSMAWBTwHQt/Y4VOpIfDjpUFgMa2pCvVtSwjnMw2ff85b0E7Enjb?= =?us-ascii?Q?9OlGY1pN+wBSzdPK9M5CHKA98mrc+9kQC+EMt2vJFpVSqr1NF+eAt0moNC1d?= =?us-ascii?Q?yPpyyILkgevUrwcGhsUgFnzXpGlKc4wJm4DWdrgcH/3wd/hmtrvF/K++7yRs?= =?us-ascii?Q?z/mWX5xupG+NYXDNfE/MPFLcX2SX43z4QU25RDGvylvNKQkpzFRvsxVseoqy?= =?us-ascii?Q?MB/jVhbkxKUjpWBJkRHI5doo4GTwtafvT2/iXvERBjFEMOZ2MYFcuxwGGFFC?= =?us-ascii?Q?4MhsXTXFFdt40CG9o7xwm3LWkuiw7d4O9mtMZgjZGYgA5pfdhRQSjmaJQRRd?= =?us-ascii?Q?9KIdM5zGpSBSrbBP8RWwaHMOKBevV2UN8XOix3EOpd6lfnoM4paU+TjvdAAp?= =?us-ascii?Q?GLexAykiD5QLBCwdyBczjKM/fbpBKmHa6iaIbfL/juedKEi+lldRtvYiH8Nv?= =?us-ascii?Q?X67taPCfGFBSMnAE1W6pWc94kG8iBoJUQoW3JZ0Q+kVCEoKVvDLEsnAihEWn?= =?us-ascii?Q?kNTOEQ87DfR8UxMjVHLl4lKQ6yl+4v5UHXu4GSxJvW2fibocY9aYYLrfGDYx?= =?us-ascii?Q?v071mMQeaSCGcI01vKhi+JE75beIB1RiVyR0g/DUgMSiS4LA5DrNeUeaUe8P?= =?us-ascii?Q?KP5yeW5CNRk8VAvCDwaKTV3Dg86lBz8+eRzRqjNcVAWeDRDJt9IsBhjVDaXX?= =?us-ascii?Q?LYDk06MgE3bXujfvKZgJrGm5t1XmLxRy8ASzcxl0gkE4jSFL?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ea261e4-f415-483a-979b-08dea2d5eaea X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2026 14:21:18.7110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IbK6qjbWvIvPVG1BFYv04c8r7Oqvdjcc6N6bz3U4uRw/5r7juuKPTelf0CiOoGan X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7035 On 25 Apr 2026, at 9:35, Sunny Patel wrote: > When check_stable_address_space() fails after the PMD spinlock has > been acquired via pmd_lock(), the code jumps directly to the abort > label, bypassing the spin_unlock() call in unlock_abort. This causes > the PMD spinlock to be permanently held, leading to a deadlock. > > Change the goto target from abort to unlock_abort to ensure the > spinlock is always released on this error path. > > Signed-off-by: Sunny Patel > --- > mm/migrate_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > LGTM. Acked-by: Zi Yan -- Best Regards, Yan, Zi