From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756739AbdJKByo (ORCPT ); Tue, 10 Oct 2017 21:54:44 -0400 Received: from mga07.intel.com ([134.134.136.100]:40845 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbdJKBym (ORCPT ); Tue, 10 Oct 2017 21:54:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,359,1503385200"; d="scan'208";a="1229409931" From: "Zhang, Tina" To: Joonas Lahtinen , "alex.williamson@redhat.com" , "kraxel@redhat.com" , "chris@chris-wilson.co.uk" , "zhenyuw@linux.intel.com" , "Lv, Zhiyuan" , "Wang, Zhi A" , "Tian, Kevin" , "daniel@ffwll.ch" , "kwankhede@nvidia.com" CC: Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "intel-gvt-dev@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: RE: [Intel-gfx] [PATCH v15 6/7] drm/i915: Introduce GEM proxy Thread-Topic: [Intel-gfx] [PATCH v15 6/7] drm/i915: Introduce GEM proxy Thread-Index: AQHTQa4AYqlrvSdQo0mOuh2Am06ISaLcY9AAgAAiwgCAAV19cA== Date: Wed, 11 Oct 2017 01:54:37 +0000 Message-ID: <237F54289DF84E4997F34151298ABEBC7C5EE7DB@SHSMSX101.ccr.corp.intel.com> References: <1507629007-3183-1-git-send-email-tina.zhang@intel.com> <1507629007-3183-7-git-send-email-tina.zhang@intel.com> <1507633082.7677.3.camel@linux.intel.com> <1507640546.7677.16.camel@linux.intel.com> In-Reply-To: <1507640546.7677.16.camel@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9B1smex002062 > -----Original Message----- > From: Joonas Lahtinen [mailto:joonas.lahtinen@linux.intel.com] > Sent: Tuesday, October 10, 2017 9:02 PM > To: Zhang, Tina ; alex.williamson@redhat.com; > kraxel@redhat.com; chris@chris-wilson.co.uk; zhenyuw@linux.intel.com; Lv, > Zhiyuan ; Wang, Zhi A ; Tian, > Kevin ; daniel@ffwll.ch; kwankhede@nvidia.com > Cc: Daniel Vetter ; intel-gfx@lists.freedesktop.org; > intel-gvt-dev@lists.freedesktop.org; linux-kernel@vger.kernel.org > Subject: Re: [Intel-gfx] [PATCH v15 6/7] drm/i915: Introduce GEM proxy > > On Tue, 2017-10-10 at 13:58 +0300, Joonas Lahtinen wrote: > > On Tue, 2017-10-10 at 17:50 +0800, Tina Zhang wrote: > > > GEM proxy is a kind of GEM, whose backing physical memory is pinned > > > and produced by guest VM and is used by host as read only. With GEM > > > proxy, host is able to access guest physical memory through GEM > > > object interface. As GEM proxy is such a special kind of GEM, a new > > > flag I915_GEM_OBJECT_IS_PROXY is introduced to ban host from > > > changing the backing storage of GEM proxy. > > > > > > v14: > > > - return -ENXIO when gem proxy object is banned by ioctl. > > > (Chris) (Daniel) > > > > > > v13: > > > - add comments to GEM proxy. (Chris) > > > - don't ban GEM proxy in i915_gem_sw_finish_ioctl. (Chris) > > > - check GEM proxy bar after finishing i915_gem_object_wait. (Chris) > > > - remove GEM proxy bar in i915_gem_madvise_ioctl. > > > > > > v6: > > > - add gem proxy barrier in the following ioctls. (Chris) > > > i915_gem_set_caching_ioctl > > > i915_gem_set_domain_ioctl > > > i915_gem_sw_finish_ioctl > > > i915_gem_set_tiling_ioctl > > > i915_gem_madvise_ioctl > > > > > > Signed-off-by: Tina Zhang > > > Cc: Daniel Vetter > > > Cc: Chris Wilson > > > Cc: Joonas Lahtinen > > > > > > > > > +++ b/drivers/gpu/drm/i915/i915_gem_object.h > > > @@ -39,6 +39,7 @@ struct drm_i915_gem_object_ops { > > > unsigned int flags; > > > #define I915_GEM_OBJECT_HAS_STRUCT_PAGE BIT(0) > > > #define I915_GEM_OBJECT_IS_SHRINKABLE BIT(1) > > > +#define I915_GEM_OBJECT_IS_PROXY BIT(2) > > > > Please fix the indent to match. Do convert the above two lines to use > > TAB character too. > > > > > > > > > @@ -1690,7 +1704,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, > void *data, > > > */ > > > if (!obj->base.filp) { > > > i915_gem_object_put(obj); > > > - return -EINVAL; > > > + return -ENXIO; > > > } > > > > This still needs to be a separate patch. > > > > With those fixes, this is; > > > > Reviewed-by: Joonas Lahtinen > > Also, send the produced two patches (this and the split patch) as a standalone > series for easier testing and merging. Got it. Thanks. BR, Tina > > CI seems to have hard time applying the whole series. > > Regards, Joonas > -- > Joonas Lahtinen > Open Source Technology Center > Intel Corporation