From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72DFDC76190 for ; Tue, 23 Jul 2019 01:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 518D821955 for ; Tue, 23 Jul 2019 01:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387700AbfGWBIY convert rfc822-to-8bit (ORCPT ); Mon, 22 Jul 2019 21:08:24 -0400 Received: from mga07.intel.com ([134.134.136.100]:4110 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731796AbfGWBIX (ORCPT ); Mon, 22 Jul 2019 21:08:23 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 18:08:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,297,1559545200"; d="scan'208";a="196941132" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 22 Jul 2019 18:08:22 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jul 2019 18:08:22 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jul 2019 18:08:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.232]) with mapi id 14.03.0439.000; Tue, 23 Jul 2019 09:08:20 +0800 From: "Zhang, Tina" To: Alex Williamson , "Lu, Kechen" CC: "intel-gvt-dev@lists.freedesktop.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kraxel@redhat.com" , "zhenyuw@linux.intel.com" , "Lv, Zhiyuan" , "Wang, Zhi A" , "Tian, Kevin" , "Yuan, Hang" Subject: RE: [RFC PATCH v4 2/6] vfio: Introduce vGPU display irq type Thread-Topic: [RFC PATCH v4 2/6] vfio: Introduce vGPU display irq type Thread-Index: AQHVPT54hV4tNMEB+k2gOpC4yrLztKbRnH8AgAP/hYCAAO5GAIAA1wdg Date: Tue, 23 Jul 2019 01:08:19 +0000 Message-ID: <237F54289DF84E4997F34151298ABEBC876BC9AD@SHSMSX101.ccr.corp.intel.com> References: <20190718155640.25928-1-kechen.lu@intel.com> <20190718155640.25928-3-kechen.lu@intel.com> <20190719102516.60af527f@x1.home> <31185F57AF7C4B4F87C41E735C23A6FE64E06F@shsmsx102.ccr.corp.intel.com> <20190722134124.16c55c2f@x1.home> In-Reply-To: <20190722134124.16c55c2f@x1.home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWUxMTJiZjQtN2I4Ni00MmFlLWE5YjctOGU2MjM4NmQyZDhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWkYxNmlpN2I2dzg1blk0VXVNRWt6K1JnRkdIZnRVcWxtZUhDc1o3ZVc4bEYrK3BZTUowdVoyVVNhaHJZNHFGeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Alex Williamson [mailto:alex.williamson@redhat.com] > Sent: Tuesday, July 23, 2019 3:41 AM > To: Lu, Kechen > Cc: intel-gvt-dev@lists.freedesktop.org; kvm@vger.kernel.org; linux- > kernel@vger.kernel.org; Zhang, Tina ; > kraxel@redhat.com; zhenyuw@linux.intel.com; Lv, Zhiyuan > ; Wang, Zhi A ; Tian, Kevin > ; Yuan, Hang > Subject: Re: [RFC PATCH v4 2/6] vfio: Introduce vGPU display irq type > > On Mon, 22 Jul 2019 05:28:35 +0000 > "Lu, Kechen" wrote: > > > Hi, > > > > > -----Original Message----- > > > From: Alex Williamson [mailto:alex.williamson@redhat.com] > > > Sent: Saturday, July 20, 2019 12:25 AM > > > To: Lu, Kechen > > > Cc: intel-gvt-dev@lists.freedesktop.org; kvm@vger.kernel.org; linux- > > > kernel@vger.kernel.org; Zhang, Tina ; > > > kraxel@redhat.com; zhenyuw@linux.intel.com; Lv, Zhiyuan > > > ; Wang, Zhi A ; Tian, > > > Kevin ; Yuan, Hang > > > Subject: Re: [RFC PATCH v4 2/6] vfio: Introduce vGPU display irq > > > type > > > > > > On Thu, 18 Jul 2019 23:56:36 +0800 > > > Kechen Lu wrote: > > > > > > > From: Tina Zhang > > > > > > > > Introduce vGPU specific irq type VFIO_IRQ_TYPE_GFX, and > > > > VFIO_IRQ_SUBTYPE_GFX_DISPLAY_IRQ as the subtype for vGPU display > > > > > > > > Signed-off-by: Tina Zhang > > > > --- > > > > include/uapi/linux/vfio.h | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > > > > index be6adab4f759..df28b17a6e2e 100644 > > > > --- a/include/uapi/linux/vfio.h > > > > +++ b/include/uapi/linux/vfio.h > > > > @@ -469,6 +469,9 @@ struct vfio_irq_info_cap_type { > > > > __u32 subtype; /* type specific */ }; > > > > > > > > +#define VFIO_IRQ_TYPE_GFX (1) > > > > +#define VFIO_IRQ_SUBTYPE_GFX_DISPLAY_IRQ (1) > > > > + > > > > > > Please include a description defining exactly what this IRQ is intended to > signal. > > > For instance, if another vGPU vendor wanted to implement this in > > > their driver and didn't have the QEMU code for reference to what it > > > does with the IRQ, what would they need to know? Thanks, > > > > > > Alex > > > > > > > Yes, that makes more sense. I'll add the description for it at next version > patch. > > > > BTW, may I have one more question? In the current design ideas, we > > partitioned the vGPU display eventfd counted 8-byte value into at most > > 8 events to deliver multiple display events, so we need different > > increasement counter value to differentiate the events. As this is the > > exposed thing the QEMU has to know, we plan adds a macro here > > VFIO_IRQ_SUBTYPE_GFX_DISPLAY_EVENTFD_BASE_SHIFT to make sure > the > > partitions shift in 1 byte, does it make sense putting here? Looking forward > to your and Gerd's comments. Thanks! > > Couldn't you expose this as another capability within the IRQ_INFO return > data? If you were to define it as a macro, I assume that means it would be > hard coded, in which case this probably becomes an Intel specific IRQ, rather > than what appears to be framed as a generic graphics IRQ extension. A new > capability could instead allow the vendor to specify their own value, where > we could define how userspace should interpret and make use of this value. > Thanks, Good suggestion. Currently, vfio_irq_info is used to save one irq info. What we need here is to use it to save several events info. Maybe we could figure out a general layout of this capability so that it can be leveraged by others, not only for display irq/events. Thanks. BR, Tina > > Alex