Re: [PATCH 0/2] platform: Enable ACPI WMI and ASUS WMI driver for ARM64

[Hans de Goede <hansg@kernel.org>]

Hi,

On 17-Sep-26 04:10, chipang_kao wrote:
> This series enables ACPI WMI core support and the ASUS WMI platform
> driver on ARM64 architectures.
> 
> ACPI WMI is not limited to x86 platforms. Modern ARM64 laptops and
> platforms have adopted ACPI WMI to expose vendor-specific features
> such as hotkeys and fan control.
> 
> To support these devices:
> 1. Removes the strict 'X86' dependency from CONFIG_ACPI_WMI.
> 2. Updates the ARM64 platform driver infrastructure to allow
>    building the ASUS WMI driver without duplicating source code.

This cover-letter is missing some important information, namely
why do this.

Yes ACPI / WMI is used on some ARM64 laptops, but AFAIK all of
those are currently still booting through Devicetree since
the current generation ARM64 laptops is missing various info Linux
needs in the ACPI tables. So for a fully functional system 
Devicetree is necessary.

I think making the generic WMI code availabe on ARM64 is good
and this is something which Armin has already been working on.

But I wonder what the concrete use-case is to build the ASUS WMI
driver on ARM64.

Questions:

1. Has this been tested on an actual Asus ARM64 laptop or other
   ARM64 device? 

2. On which laptop/device model ?

3. How was this tested, how was the laptop booted; and does booting
   it this way lead to loosing any other functionality

4. Were any other kernel patches used during testing?

As for patch 2/2 I think that if we want this the driver should
simply be moved to platform/wmi .

Regards,

Hans



> 
> chipang_kao (2):
>   platform/wmi: Remove X86 dependency for ACPI_WMI
>   platform/arm64: Enable ASUS WMI driver support
> 
>  drivers/platform/arm64/Kconfig  | 46 +++++++++++++++++++++++++++++++++
>  drivers/platform/arm64/Makefile |  2 ++
>  drivers/platform/wmi/Kconfig    |  2 +-
>  3 files changed, 49 insertions(+), 1 deletion(-)
>