From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C5C9C433EF for ; Tue, 28 Jun 2022 11:21:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345057AbiF1LVb (ORCPT ); Tue, 28 Jun 2022 07:21:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231135AbiF1LV2 (ORCPT ); Tue, 28 Jun 2022 07:21:28 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E7612E096; Tue, 28 Jun 2022 04:21:25 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 50C9022246; Tue, 28 Jun 2022 13:21:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1656415283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o0W1KL9ji+DqAJcOrvQpkrdf1niwtlqNX9ZRyuRODlc=; b=Uw/+x6420mcEOIknrJiEYJ4HEZ9UvXxfVZ6Pn1XCw8CkN8ZGwdtezuxBiGXY9vgiFgK+id sco96ziMUq3tHBPtXx1MXH+QQqiDvIx8fvuL4jvAgnBNt55ZQvjmWQN85TQ3PPNa+fhfRq BeLUsNnjDbN9kU5q2xkTkA5N5rh6MDc= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Jun 2022 13:21:23 +0200 From: Michael Walle To: Rob Herring , Frank Rowand , Greg Kroah-Hartman , Jiri Slaby Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v2] earlycon: prevent multiple register_console() In-Reply-To: <20220602090038.3201897-1-michael@walle.cc> References: <20220602090038.3201897-1-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <2386f29173c6a6d31e3e07630a44eafb@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 2022-06-02 11:00, schrieb Michael Walle: > If the earlycon parameter is given twice, the kernel will spit out a > WARN() in register_console() because it was already registered. The > non-dt variant setup_earlycon() already handles that gracefully. The dt > variant of_setup_earlycon() doesn't. Add the check there and add the > -EALREADY handling in early_init_dt_scan_chosen_stdout(). > > FWIW, this doesn't happen if CONFIG_ACPI_SPCR_TABLE is set. In that > case > the registration is delayed until after earlycon parameter(s) are > parsed. > > Signed-off-by: Michael Walle Ping :) Or do I have to resend this patch? -michael