From: Valdis.Kletnieks@vt.edu
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: akpm@linux-foundation.org, axboe@kernel.dk, oakad@yahoo.com,
tj@kernel.org, mm-commits@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [merged] memstick-add-support-for-legacy-memorysticks.patch removed from -mm tree
Date: Sun, 07 Jul 2013 22:11:16 -0400 [thread overview]
Message-ID: <239047.1373249476@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 08 Jul 2013 03:41:42 +0300." <1373244102.18009.6.camel@maxim-laptop>
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On Mon, 08 Jul 2013 03:41:42 +0300, Maxim Levitsky said:
> +/* Debug test to validate free block counts */
> +#ifdef DEBUG
> +static int msb_validate_used_block_bitmap(struct msb_data *msb)
> +{
Is there a reason this should be inside a #ifdef DEBUG with no
easy way to select DEBUG? Maybe CONFIG_MS_BLOCK_DEBUG similar to
the way other subsystems allow configuring additional debug code?
[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]
next prev parent reply other threads:[~2013-07-08 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121001192920.0D7765C0050@hpza9.eem.corp.google.com>
2013-07-08 0:41 ` Maxim Levitsky
2013-07-08 2:11 ` Valdis.Kletnieks [this message]
2013-07-08 14:11 ` Maxim Levitsky
2013-07-08 20:54 ` Driver for memestick standard cards Maxim Levitsky
2013-07-08 20:54 ` [PATCH] memstick: add support for legacy memorysticks Maxim Levitsky
2013-07-11 0:28 ` Maxim Levitsky
2013-07-11 21:22 ` Andrew Morton
2013-07-17 20:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=239047.1373249476@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=mm-commits@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®