From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org,
linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [PATCH] acpi: don't register acpi_pad driver if running as xen dom0
Date: Fri, 14 Oct 2016 00:00:08 +0200 [thread overview]
Message-ID: <2390542.It4zVIG3Mc@vostro.rjw.lan> (raw)
In-Reply-To: <1476270705-16209-1-git-send-email-jgross@suse.com>
On Wednesday, October 12, 2016 01:11:45 PM Juergen Gross wrote:
> When running as Xen dom0 a special processor_aggregator driver is
> needed. Don't register the standard driver in this case.
>
> Without that check an error message:
>
> "Error: Driver 'processor_aggregator' is already registered,
> aborting..."
>
> will be displayed.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> drivers/acpi/acpi_pad.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
> index 8ea8211..1c3be12 100644
> --- a/drivers/acpi/acpi_pad.c
> +++ b/drivers/acpi/acpi_pad.c
> @@ -26,6 +26,7 @@
> #include <linux/slab.h>
> #include <linux/acpi.h>
> #include <asm/mwait.h>
> +#include <xen/xen.h>
>
> #define ACPI_PROCESSOR_AGGREGATOR_CLASS "acpi_pad"
> #define ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME "Processor Aggregator"
> @@ -477,6 +478,10 @@ static struct acpi_driver acpi_pad_driver = {
>
> static int __init acpi_pad_init(void)
> {
> + /* Xen acpi pad is responsible when running as Xen Dom0. */
> + if (xen_initial_domain())
> + return -ENODEV;
> +
> power_saving_mwait_init();
> if (power_saving_mwait_eax == 0)
> return -EINVAL;
>
Applied.
Thanks,
Rafael
prev parent reply other threads:[~2016-10-13 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 11:11 Juergen Gross
2016-10-13 22:00 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2390542.It4zVIG3Mc@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=jgross@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®