From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936254AbcISHe4 (ORCPT ); Mon, 19 Sep 2016 03:34:56 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50323 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbcISHet (ORCPT ); Mon, 19 Sep 2016 03:34:49 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, Qingqing.Wang@amd.com, Monk.Liu@amd.com, JinHuiEric.Huang@amd.com, Rex.Zhu@amd.com, nils.wallmenius@gmail.com, ray.huang@amd.com, Young.Yang@amd.com, Flora.Cui@amd.com, Jammy.Zhou@amd.com, funfunctor@folklore1984.net, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible Date: Mon, 19 Sep 2016 09:34:22 +0200 Message-ID: <2392100.i5YbeLyK7H@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474270119-8500-1-git-send-email-baoyou.xie@linaro.org> References: <1474270119-8500-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:WSdUFvBIWlHaceRvMKK84ZpesIvmRYv9PpXnyFIL+m7SxeVahwC 1mQuA2tHJbL9lTxzrbjvmXaNz8pDoaEZeK48oNCMSfGkwtjRBpbY9Mltsff2DSElgOh885l bZjj68zCJtBKGkbf5JaPAqAVALP1hUk27oQph2sZGpkXckYuwl4cP0zQD5oV8gLLv0wtaxA AvtbZL3CscjCJx6ZOil0g== X-UI-Out-Filterresults: notjunk:1;V01:K0:1zH1PZ/MGhw=:6MNIhVMZfAkbPle1sG/xAK RB43GfL199VkAUhARLZH5Tppo7U5ASp94Lmct0EKTsd3CbCwWC830BB+LotcZOxt5GBG0z09P 4HHzvbaoRkHu5ihMRDKxwdyz6zKGf8Z/oCxpdkSRzNPK/u2xXIfeki3rJEqL4Mg6acTTJlQMH sWsUrZd9iMmNsk96N3+0LB6Cx4gq5djlmtQsk2BEEeUShDbO+2fQc39q9la7qMd24Z49+FBUJ CuHj9ha7ao+HtCA/LqoVc2l1Pa4h0MQ9SpF4SZLOM1CdbpDwxCCeuyOk9BZhrY8GD+L8PeGRt FXFgCnBIzoi9AXhx70rD1wkmj7tW3kMzhnNjK+A4WQnD7UPRL5mGt5V/7cK6drm4zdY7UOKhA 3SVF6By8ARVKjoO+iitXYd6vRJ8eCEeoUomjVP9iSBmsxyeGyez+zfNTTydf4YvUeH7o6bR1h sY/PrZS1hsN+hmAgxmTb2onnzZs6A68dkwNmMHLDiK8K7A0RD0hu0GhBvXeWNuhQS1x7ZdsN3 k1r1A6njiph0+X2Y8Xl0tU0hyDfowtjEOKqX2eRjyHK9u5AbR1G6NaEwyKXltEC6mAD4KK0L9 gjMtepF2dr+tp/l6aoEhbcJta+0OUgf2RML3wXPJQvHvbZzdyPSgBfAfO6oKjpxN10OAB/tsD fbmOvn1gU18UQp7qMBmeIyCnc8iaMWFBpipoZRcLEgmHLnnQj8MpeD4rC9wLeyw/EQ6bc7R4J +Os927kmnUV3C9W+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, September 19, 2016 3:28:39 PM CEST Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning: no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:816:5: warning: no previous prototype for 'fiji_save_vft_table' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:743:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/iceland_smumgr.c:167:5: warning: no previous prototype for 'iceland_program_jump_on_start' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > Hi Baoyou, All your drm/amd patches seem fine to me, but again (as with the nouveau driver patches before), I think it would make more sense to consolidate them, and do a small number of patches such as [PATCH 1/3] drm/amdgpu: add missing includes [PATCH 2/3] drm/amdgpu: remove unused functions [PATCH 3/3] drm/amdgpu: mark symbol static where possible This is all one big driver, and I see no value in splitting it up per file within the driver. Arnd