From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbcLEVzU convert rfc822-to-8bit (ORCPT ); Mon, 5 Dec 2016 16:55:20 -0500 Received: from mga05.intel.com ([192.55.52.43]:35591 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbcLEVzS (ORCPT ); Mon, 5 Dec 2016 16:55:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,749,1477983600"; d="scan'208";a="1077830438" From: "Dilger, Andreas" To: Dan Carpenter CC: James Simmons , "devel@driverdev.osuosl.org" , Greg Kroah-Hartman , Linux Kernel Mailing List , "Drokin, Oleg" , Lustre Development List Subject: Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions Thread-Topic: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions Thread-Index: AQHSTzlJg/DjR/jRFEWFfELUtA77FaD6bBgA Date: Mon, 5 Dec 2016 21:55:04 +0000 Message-ID: <2394CAB0-41C1-4F3B-AF94-03D302F6ABF5@intel.com> References: <1480707650-24089-1-git-send-email-jsimmons@infradead.org> <1480707650-24089-4-git-send-email-jsimmons@infradead.org> <20161205205005.GA31243@mwanda> In-Reply-To: <20161205205005.GA31243@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.204.117] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Dec 5, 2016, at 13:50, Dan Carpenter wrote: > > On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: >> - __u32 local_flags = 0; >> + u32 local_flags = 0; > >> - if (local_flags != 0) { >> + if (local_flags) { > > Please avoid these unrelated white space changes. Some projects (e.g. ext4 that I work with most) allow whitespace changes as part of related changes to the code, since the code is being modified anyway, and frown upon whitespace-only changes because they cause churn in the code and otherwise introduce patch merge conflicts for relatively minor benefits by themselves. My preference is to allow whitespace cleanups in code being modified as part of a patch that is making other fixes, since a few whitespace changes don't typically make it any harder to review the patch. If it gets so far as moving blocks of code between files and this doesn't appear cleanly in the patch then I'd ask for a separate patch. Cheers, Andreas