From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C448C8CE for ; Tue, 3 Mar 2026 07:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521347; cv=none; b=XTFGw/eh47sMPTmxR27zcBYgbfZm84kQGMTaYvRBhfgUFZruuYJZF/64hxnkVzp+p682grtCyDpZBnSqdFAw8r8QqTN52ceTC5xFz1Zz3I3+qOqvwuVmLEl9Bqo8cHLJifPxD2yqoYbutHz6fhlZqktcVduSngq7AJTfZ1Le978= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521347; c=relaxed/simple; bh=zXWwEcF1v33xG1KMy07wLyyPGmeN87goQXiWtzMkLOg=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=VGKhNWmQl0DbBrml9i0WtlRE0tlG9EFosURY33MejgZB/cQ4stB1xCrcPKDn8zp5XOcJOgk1GiWTfcFiRyUbMP86T4HhMfItYs4k28ZHpbvajK6S/SoMLwEqGpoVk/Ajhg+ZL8YDyYsejV/c+jfxMZEyVKEecYxv4UwXEbgfh1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GoPuSxd9; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GoPuSxd9" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4376acce52eso3512120f8f.1 for ; Mon, 02 Mar 2026 23:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772521345; x=1773126145; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zXWwEcF1v33xG1KMy07wLyyPGmeN87goQXiWtzMkLOg=; b=GoPuSxd9eyLz96GN8RKt3Ko5Ksvr5j89aqMfdwQ91Cnxfom1lwde6ij0KLNRY9T9AP 6ipsZtg9bvXK9r4dGwnWDl/10zE1XrvrgHPLH/yBBGIJTdj5X7F9000bFFQPAeDKhBwc mGoWN+hGgc190o2lQirytq8O+gAjqeSNvSTGdYlKzelFYyupT/g+RTr4S0gdEI27am4x S62oL7sXca7Mv+dJQBOzMLDhmAveEHRPcbh+vDKoidr5ufSa4fNMTEvjQJvI4w0NN28Q l9OavFL1zRVXM+Rrh1k7LAF5NHuK/qptZDp8UaIjgG7tEJcrisIKt6JtDnZ3uJmAicnN w4AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772521345; x=1773126145; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zXWwEcF1v33xG1KMy07wLyyPGmeN87goQXiWtzMkLOg=; b=XMqzr3kZYK/m153Qm6ccwPvBFK6cNPkcMc5jWzUl79kMat5ZKJwQGNed+T7Lhn++cP 1mHkLYeLcIpx8J1CzR/rggYVnOqklO8WXudmUja7PjjPdSgyvRC3PmJD+3U0gzhZIG4L mVhRRE3Hh++rTev7AMrqKo4xXcAV4PZSmN7J/3/2c7O/rqSDXyrg+xrOsH7FZ6Rm/f1G ZUVbCj+x/RCuHHzRYjWiwtScTcBLWd+p81zOIrD0ynopWpNXi5jEO0VxmYCReW5Zucde DQthTMC2T30yiZ4Ho8JEe+5mTXSCC7WsOnpkBqaVZWklpc0/dGAqQPWN4ct1+V6foPCH gH6Q== X-Forwarded-Encrypted: i=1; AJvYcCUlQ+b/+VP+Q9w5ggCHHPhMd6Gs+WSjnUr9ezbl92UuanbO98DMAsZAcaod0FLKjesA5M3nb5M3TNgCZcY=@vger.kernel.org X-Gm-Message-State: AOJu0YzgTgmN2ZLX7BVeI335KOsD4fSIn+TuUrrDyODfLnXcbYUJMNg0 SvWwOou1OJnGry8nOS9ITBs8s9QOdtYCpVKHcZ9glzEhdlbLnI1Zb/lQ X-Gm-Gg: ATEYQzyZouIhm/MOt4ofpRO2bPhqRF5bwBDXFFwAW9Ejo1v8k7c9a/eY3W+2gdxqIjE MmE2PAGr0WhaAwKzNDQf3bMbS/2ZWu6+qONzudbliqb8dDUR9C53zFDJDi4hy1OI9280k8rq/KE oGmL9mn9KjT3t4pCX1Dd9Yb+U5AYCAUiiyM6leroQU9hofdm9lgZWUR5TZW1HjPbq8pFf+BAFpi 54HdQ2UmGoevDzAhrjfVy/Sg/6/HCMWag6kYJxycGsPt/IeMorgRlH2WENMHtJWBudY/kBvdVRt hVVGtMxHZ/g9jZDNuFd+GOy4/q9cyUTOyPrhYbEMxfTeXU3HXoHXL+eDvoAilEiC+9EDblz6Lgr QAp5VPCKvsEq49poFNa406p42DZGuG9bzn7IEjarCPq2OKAMtnVbGTPObRJ5RcvPiuEK9nAPcc5 Icy8Fu4qwTPxqgAUIfcvTYsUIGLtA= X-Received: by 2002:a5d:5f93:0:b0:439:be4b:6874 with SMTP id ffacd0b85a97d-439be4b6937mr5611994f8f.49.1772521344477; Mon, 02 Mar 2026 23:02:24 -0800 (PST) Received: from [127.0.0.1] ([86.1.69.5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b130abfasm17500405f8f.34.2026.03.02.23.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 23:02:24 -0800 (PST) Date: Tue, 3 Mar 2026 07:02:19 +0000 From: Josh Law To: Dan Carpenter Cc: Greg Kroah-Hartman , Ovidiu Panait , Gabriel Shahrouzi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Message-ID: <239a788f-7ed4-4bd2-8ad7-8d0783bcdaf1@gmail.com> In-Reply-To: References: <20260301214815.2628942-1-objecting@objecting.org> <20260301214815.2628942-5-objecting@objecting.org> Subject: Re: [PATCH v2 05/10] staging: axis-fifo: improve IRQ handler Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <239a788f-7ed4-4bd2-8ad7-8d0783bcdaf1@gmail.com> 3 Mar 2026 06:10:13 Dan Carpenter : > On Mon, Mar 02, 2026 at 03:55:36PM +0000, Josh Law wrote: >> 2 Mar 2026 08:14:53 Dan Carpenter : >> >>> On Sun, Mar 01, 2026 at 09:48:10PM +0000, Josh Law wrote: >>>> From: Josh Law >>>> >>>> Return IRQ_NONE when no interrupts were triggered to avoid spurious >>>> interrupt storms, and only clear the active interrupts instead of >>>> blindly clearing all interrupts by writing 'intr' to the ISR instead o= f >>>> XLLF_INT_CLEAR_ALL. >>>> >>> >>> Is this something you actually experienced in real life?=C2=A0 The comm= it >>> message needs to be clearer about that. >>> >>> regards, >>> dan carpenter >> >> Hello Dan, It's just code optimizations, making it cleaner, etc, I >> also ran all of these latest V2 commits through check patch, to make >> sure they are compliant, I own this device so I hope I can be the >> maintainer of it one day, I'm learning this Linux system day by day, >> so I am sorry I have to annoy a professional linaro dev like you haha >> > > I don't mind reviewing patches.=C2=A0 The cleanups are easy to review.=C2= =A0 In > this case it's a behavior change and so I would want a clearer picture > the motivation and of how well these have been tested for that. > > regards, > dan carpenter Lol, are you gonna approve ANY of my patches haha V/R