From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
Date: Thu, 28 Apr 2022 09:06:27 +0200 [thread overview]
Message-ID: <239ae645-7fb1-ca8c-1b37-2238313d6d1f@suse.com> (raw)
In-Reply-To: <d4d36fb2-a26a-9fbd-acc6-fe97ab93fa66@oracle.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 779 bytes --]
On 21.04.22 22:56, Boris Ostrovsky wrote:
>
> On 4/21/22 4:40 AM, Juergen Gross wrote:
>> On 20.04.22 18:12, Boris Ostrovsky wrote:
>>> And also looking at invocations of scsiback_do_resp_with_sense() I think
>>> those may need to be adjusted as well.
>>
>> No, the invocations are fine, but scsiback_result() needs to pass through
>> the lowest 16 bits instead of only the lowest 8 bits of the result value.
>>
>
> What I was thinking was that this could use the reverse of
> XEN_VSCSIIF_RSLT_HOST(), i.e. something like
>
> #define RSLT_HOST_TO_XEN_VSCSIIF(x) ((x)<<16)
>
> to be explicit about namespaces.
I don't think this is needed.
> BTW, should scsiback_result() use XEN_VSCSIIF_RSLT_HOST() at the top?
Yes, I'll do that.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-04-28 7:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 9:24 [PATCH 0/4] xen/pv-scsi: update header and harden frontend Juergen Gross
2022-04-20 9:25 ` [PATCH 1/4] xen: update vscsiif.h Juergen Gross
2022-04-20 9:25 ` [PATCH 2/4] xen/scsiback: use new command result macros Juergen Gross
2022-04-20 16:12 ` Boris Ostrovsky
2022-04-21 8:40 ` Juergen Gross
2022-04-21 20:56 ` Boris Ostrovsky
2022-04-28 7:06 ` Juergen Gross [this message]
2022-04-20 9:25 ` [PATCH 3/4] xen/scsifront: " Juergen Gross
2022-04-20 9:25 ` [PATCH 4/4] xen/scsifront: harden driver against malicious backend Juergen Gross
2022-04-20 16:13 ` Boris Ostrovsky
2022-04-21 10:13 ` Juergen Gross
2022-04-21 15:29 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=239ae645-7fb1-ca8c-1b37-2238313d6d1f@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®